You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/09/19 21:54:03 UTC
[PR] Drop Hamcrest from tests [maven-jarsigner-plugin]
slachiewicz opened a new pull request, #167:
URL: https://github.com/apache/maven-jarsigner-plugin/pull/167
Replaces Hamcrest matchers and assertThat with JUnit 5 Assertions (assertTrue/assertFalse on String.contains/startsWith) and drops the org.hamcrest test dependency. RequestMatchers stays as a matcher-factory class but its factories now implement org.mockito.ArgumentMatcher instead of org.hamcrest.TypeSafeMatcher, so call sites via Mockito argThat are unchanged in shape; assertThat(list, everyItem/hasItem(...)) becomes stream().allMatch/anyMatch(matcher::matches).
Verified: mvn verify → BUILD SUCCESS, 48 tests (unchanged from baseline).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Drop Hamcrest from tests [maven-jarsigner-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #167:
URL: https://github.com/apache/maven-jarsigner-plugin/pull/167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org