[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #7323: Bump FAB to 2.0.0

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #7323: Bump FAB to 2.0.0
URL: https://github.com/apache/incubator-superset/pull/7323#discussion_r277236660
 
 

 ##########
 File path: superset/__init__.py
 ##########
 @@ -202,7 +201,6 @@ def index(self):
     base_template='superset/base.html',
     indexview=MyIndexView,
     security_manager_class=custom_sm,
-    update_perms=get_update_perms_flag(),
 
 Review comment:
   FAB defaults to `True` on `update_perms`, so that we get the same behavior.
   My reasoning is that the present change will create all permissions on start just like before.
   If we want to disable the permission creation (avoid contention on the db on startup), 
   FAB_UPDATE_PERMS=False and run `superset init` once per deploy.
   
   I would say that `appbuilder.add_permissions(update_perms=True)` can be achieved by calling the new `flask fab create-permissions`. I noticed that `superset db upgrade` creates and upgrades the db, leaving it already with bootstrap permissions and `superset init` created Superset's extra roles even with `FAB_UPDATE_PERMS=False` (so all is good).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org