You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/10/24 18:22:12 UTC
[GitHub] [accumulo] ctubbsii opened a new pull request, #3038: Trivial improvements to block cache code
ctubbsii opened a new pull request, #3038:
URL: https://github.com/apache/accumulo/pull/3038
Make trivial improvements seen while investigating #2697
* Get rid of unnecessary generic method in internal implementation
* Drop redundant static modifier on interface
* Add explicit private constructor for BlockIndex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #3038: Trivial improvements to block cache code
Posted by GitBox <gi...@apache.org>.
ctubbsii merged PR #3038:
URL: https://github.com/apache/accumulo/pull/3038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #3038: Trivial improvements to block cache code
Posted by GitBox <gi...@apache.org>.
dlmarion commented on PR #3038:
URL: https://github.com/apache/accumulo/pull/3038#issuecomment-1289465986
Does this fix a bug in 2.1.0? If not, I'd rather we punt this to a bugfix release and get RC1 underway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #3038: Trivial improvements to block cache code
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #3038:
URL: https://github.com/apache/accumulo/pull/3038#issuecomment-1289504794
> Does this fix a bug in 2.1.0? If not, I'd rather we punt this to a bugfix release and get RC1 underway.
It does not fix a bug. It just makes a few lines very slightly more readable and easier to follow. Merging it won't block an RC1, though. I have another patch to improve the assembly process itself, that I'll be merging before RC1 anyway. I don't care if we include this or not, but it's trivial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org