You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jgiannuzzi (via GitHub)" <gi...@apache.org> on 2025/10/22 11:49:09 UTC
[PR] GH-47909: [C++] Fix MSVC ARM64 build [arrow]
jgiannuzzi opened a new pull request, #47910:
URL: https://github.com/apache/arrow/pull/47910
### Rationale for this change
#47573 broke the Windows ARM64 MSVC build by trying to compile xsimd even when `ARROW_SIMD_LEVEL` is set to `NONE`.
### What changes are included in this PR?
Rename `util/bpacking_simd_default.cc` to `util/bpacking_simd_neon.cc` and compile it only when NEON SIMD is requested.
### Are these changes tested?
Yes, in the Windows ARM64 MSVC build pipeline that I was developing on #47811 when I noticed the change.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47909: [C++] Fix MSVC ARM64 build [arrow]
Posted by "jgiannuzzi (via GitHub)" <gi...@apache.org>.
jgiannuzzi commented on PR #47910:
URL: https://github.com/apache/arrow/pull/47910#issuecomment-3433118743
Thanks for the merge @pitrou! I have just rebased #47811 and it's ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47909: [C++] Fix MSVC ARM64 build [arrow]
Posted by "AntoinePrv (via GitHub)" <gi...@apache.org>.
AntoinePrv commented on PR #47910:
URL: https://github.com/apache/arrow/pull/47910#issuecomment-3432346545
Thanks for looking into this!
For reference, I did no create a `_neon` file because to reproduce the pattern used for `byte_stream_split`.
```
cpp/src/arrow/util/byte_stream_split_internal.cc
cpp/src/arrow/util/byte_stream_split_internal.h
cpp/src/arrow/util/byte_stream_split_internal_avx2.cc
cpp/src/arrow/util/byte_stream_split_test.cc
```
The fix works, but I am also working on this files, and may add an SSE compilation that will share the same xsimd code as the Neon one (hence the undescriptive `_default`).
I believe that, equivalently to the `byte_stream_split`, we can only gate the `#include`s in `bpacking_simd_default.cc` behind `#if defined(ARROW_HAVE_NEON)` to resolve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47909: [C++] Fix MSVC ARM64 build [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47910:
URL: https://github.com/apache/arrow/pull/47910#issuecomment-3431977994
:warning: GitHub issue #47909 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47909: [C++] Fix MSVC ARM64 build [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #47910:
URL: https://github.com/apache/arrow/pull/47910#issuecomment-3432197960
@AntoinePrv Could you take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47909: [C++] Fix MSVC ARM64 build [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #47910:
URL: https://github.com/apache/arrow/pull/47910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47909: [C++] Fix MSVC ARM64 build [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47910:
URL: https://github.com/apache/arrow/pull/47910#issuecomment-3434453822
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a625340dc0b9481b256944edab366e7a150a9e66.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/53431118261) has more details. It also includes information about 15 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47909: [C++] Fix MSVC ARM64 build [arrow]
Posted by "jgiannuzzi (via GitHub)" <gi...@apache.org>.
jgiannuzzi commented on PR #47910:
URL: https://github.com/apache/arrow/pull/47910#issuecomment-3432767155
Thanks for the insight, @AntoinePrv! I have tested it locally and have updated #47196 so we can see it working in the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org