You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/01 19:12:05 UTC

[GitHub] [superset] nytai opened a new pull request #12877: fix(menu): always show settings dropdown

nytai opened a new pull request #12877:
URL: https://github.com/apache/superset/pull/12877


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] dpgaspar merged pull request #12877: fix(menu): always show settings dropdown

Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #12877:
URL: https://github.com/apache/superset/pull/12877


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] adam-stasiak commented on pull request #12877: fix(menu): always show settings dropdown

Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12877:
URL: https://github.com/apache/superset/pull/12877#issuecomment-771246395


   Tested manually 🟢 
   I can see this additionally on Login screen with basic info about app as expected. Wen through roles:
   ![image](https://user-images.githubusercontent.com/25153919/106533450-7dc72b00-64f2-11eb-8963-e35eee13e288.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] adam-stasiak commented on pull request #12877: fix(menu): always show settings dropdown

Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12877:
URL: https://github.com/apache/superset/pull/12877#issuecomment-771246395


   Tested manually 🟢 
   I can see this additionally on Login screen with basic info about app as expected. Wen through roles:
   ![image](https://user-images.githubusercontent.com/25153919/106533450-7dc72b00-64f2-11eb-8963-e35eee13e288.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] dpgaspar merged pull request #12877: fix(menu): always show settings dropdown

Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #12877:
URL: https://github.com/apache/superset/pull/12877


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org