You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/29 16:19:30 UTC
[GitHub] [spark] srowen opened a new pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP] fix app id link for multi attempts app in history summary page
srowen opened a new pull request #28949:
URL: https://github.com/apache/spark/pull/28949
This is simply a backport of https://github.com/apache/spark/pull/28867 to branch-2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhli1142015 commented on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
zhli1142015 commented on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-651418623
@srowen , thanks for taking care this. This looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-652074314
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29305/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-652064555
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28949: [SPARK-32028][WEBUI][2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28949:
URL: https://github.com/apache/spark/pull/28949
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-652133816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-652133117
**[Test build #124693 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124693/testReport)** for PR 28949 at commit [`697bbd2`](https://github.com/apache/spark/commit/697bbd266b08dc3a7aac49f91c98d5209d62dc7f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-651293490
Jenkins, test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-651223197
@zhli1142015 does this back port look correct? It wasn't a 100% clean cherry-pick but I think I got the change mapped correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-652073797
**[Test build #124693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124693/testReport)** for PR 28949 at commit [`697bbd2`](https://github.com/apache/spark/commit/697bbd266b08dc3a7aac49f91c98d5209d62dc7f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-652074304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-652062209
**[Test build #124650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124650/testReport)** for PR 28949 at commit [`697bbd2`](https://github.com/apache/spark/commit/697bbd266b08dc3a7aac49f91c98d5209d62dc7f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-652073797
**[Test build #124693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124693/testReport)** for PR 28949 at commit [`697bbd2`](https://github.com/apache/spark/commit/697bbd266b08dc3a7aac49f91c98d5209d62dc7f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-652064555
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-651899526
**[Test build #124650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124650/testReport)** for PR 28949 at commit [`697bbd2`](https://github.com/apache/spark/commit/697bbd266b08dc3a7aac49f91c98d5209d62dc7f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-652133816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-652064559
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124650/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #28949: [SPARK-32028][WEBUI][FOLLOWUP][BRANCH-2.4] fix app id link for multi attempts app in history summary page
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28949:
URL: https://github.com/apache/spark/pull/28949#issuecomment-652071054
Jenkins retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org