You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/25 10:05:46 UTC
[GitHub] [flink] slinkydeveloper opened a new pull request #17906: [hotfix][table-common] Replace DataType.projectFields with Projection type
slinkydeveloper opened a new pull request #17906:
URL: https://github.com/apache/flink/pull/17906
## What is the purpose of the change
[FLINK-24399](https://issues.apache.org/jira/browse/FLINK-24399) introduced new methods to perform data types projections in `DataType`. **Note**: no release included such changes.
[FLINK-24776](https://issues.apache.org/jira/browse/FLINK-24776) introduced a new, more powerful, type to perform operations on projections, that is project types, but also difference and complement.
In spite of avoiding to provide different entrypoints for the same functionality, this PR cleanups the new methods introduced by FLINK-24399 and replaces them with the new `Projection` type. It also deprecates the old methods in `DataTypeUtils` for cleanup in future releases.
## Brief change log
* Replace every usage of `DataType#projectFields` and `DataTypeUtils#projectRow` with the new `Projection` type
* Remove `DataType#projectFields`
* Deprecate `DataTypeUtils#projectRow`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
}, {
"hash" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27283",
"triggerID" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d93c12d85edaec4c6cee2337756209b6a5ec2744 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27283)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
}, {
"hash" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27283",
"triggerID" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
* d93c12d85edaec4c6cee2337756209b6a5ec2744 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27283)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
}, {
"hash" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
* d93c12d85edaec4c6cee2337756209b6a5ec2744 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
}, {
"hash" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27283",
"triggerID" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
* d93c12d85edaec4c6cee2337756209b6a5ec2744 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27283)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
}, {
"hash" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
* d93c12d85edaec4c6cee2337756209b6a5ec2744 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aef9772b33d766c093f1e286d145ea32c757696d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052)
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17906: [hotfix][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aef9772b33d766c093f1e286d145ea32c757696d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
}, {
"hash" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
* d93c12d85edaec4c6cee2337756209b6a5ec2744 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
}, {
"hash" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
* d93c12d85edaec4c6cee2337756209b6a5ec2744 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17906:
URL: https://github.com/apache/flink/pull/17906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on a change in pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on a change in pull request #17906:
URL: https://github.com/apache/flink/pull/17906#discussion_r759172992
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/Projection.java
##########
@@ -39,9 +49,24 @@
// sealed class
private Projection() {}
- /** Project the provided {@link DataType} using this {@link Projection}. */
+ /**
+ * Projects a (possibly nested) row data type by returning a new data type that only includes
+ * fields of the given index paths.
+ *
+ * <p>Note on naming: Sometimes, it may get name conflicts when extract fields from the row
Review comment:
I reworded this comment to explain it better, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17906:
URL: https://github.com/apache/flink/pull/17906#discussion_r759206106
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/Projection.java
##########
@@ -39,9 +49,24 @@
// sealed class
private Projection() {}
- /** Project the provided {@link DataType} using this {@link Projection}. */
+ /**
+ * Projects a (possibly nested) row data type by returning a new data type that only includes
+ * fields of the given index paths.
+ *
+ * <p>Note on naming: Sometimes, it may get name conflicts when extract fields from the row
Review comment:
perfect, thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17906: [hotfix][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979057528
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit aef9772b33d766c093f1e286d145ea32c757696d (Thu Nov 25 10:10:57 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [hotfix][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aef9772b33d766c093f1e286d145ea32c757696d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
}, {
"hash" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
* d93c12d85edaec4c6cee2337756209b6a5ec2744 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aef9772b33d766c093f1e286d145ea32c757696d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052)
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aef9772b33d766c093f1e286d145ea32c757696d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052)
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #17906:
URL: https://github.com/apache/flink/pull/17906#discussion_r759119994
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/Projection.java
##########
@@ -39,9 +49,24 @@
// sealed class
private Projection() {}
- /** Project the provided {@link DataType} using this {@link Projection}. */
+ /**
+ * Projects a (possibly nested) row data type by returning a new data type that only includes
+ * fields of the given index paths.
+ *
+ * <p>Note on naming: Sometimes, it may get name conflicts when extract fields from the row
Review comment:
Could we fit the grammar in this doc for a `@PublicEvolving` interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17906: [FLINK-25060][table-common] Replace DataType.projectFields with Projection type
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17906:
URL: https://github.com/apache/flink/pull/17906#issuecomment-979056025
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aef9772b33d766c093f1e286d145ea32c757696d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27052",
"triggerID" : "aef9772b33d766c093f1e286d145ea32c757696d",
"triggerType" : "PUSH"
}, {
"hash" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059",
"triggerID" : "d0e07dd6fdc13bd6be1dffebe8e0722de923f77b",
"triggerType" : "PUSH"
}, {
"hash" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276",
"triggerID" : "13c8b90d507dae4c18dce9be92f47fadcb58eb6e",
"triggerType" : "PUSH"
}, {
"hash" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d93c12d85edaec4c6cee2337756209b6a5ec2744",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d0e07dd6fdc13bd6be1dffebe8e0722de923f77b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27059)
* 13c8b90d507dae4c18dce9be92f47fadcb58eb6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27276)
* d93c12d85edaec4c6cee2337756209b6a5ec2744 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org