You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sodonnel (via GitHub)" <gi...@apache.org> on 2023/01/24 13:18:25 UTC
[GitHub] [ozone] sodonnel opened a new pull request, #4202: HDDS-7833. EC: Refactor ReplicationSupervisor to allow Replication and ECReconstruction tasks
sodonnel opened a new pull request, #4202:
URL: https://github.com/apache/ozone/pull/4202
## What changes were proposed in this pull request?
A refactor or the existing ReplicationSupervisor so we can have the same supervisor (and threadpool) manage both Replication and EC Reconstruction tasks.
This change does not include moving the EC tasks into the ReplicationSupervisor - that will be done in another PR as this one is already large enough with this change.
This change makes ReplicationSupervisor accept AbstractReplicationTask's rather than a ReplicationTask, so we can have a version for EC Reconstruction and Ratis.
This results in the ReplicationTask having a `runTask()` method so it contains the knowledge of how to run itself and the supervisor can simply check the state. The choice of Replicator (push or download) is decided in the ReplicateContainerCommandHandler and a reference to the correct replicator is stored in the task. Previously it was decided inside the ReplicationSupervisor.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7833
## How was this patch tested?
Small change to one unit test and other existing tests should cover this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel merged pull request #4202: HDDS-7833. EC: Refactor ReplicationSupervisor to allow Replication and ECReconstruction tasks
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel merged PR #4202:
URL: https://github.com/apache/ozone/pull/4202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on pull request #4202: HDDS-7833. EC: Refactor ReplicationSupervisor to allow Replication and ECReconstruction tasks
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on PR #4202:
URL: https://github.com/apache/ozone/pull/4202#issuecomment-1402002135
> LGTM.
>
> Can these members be removed?
>
> https://github.com/apache/ozone/blob/b860e844c61de79aaa26160a0f353b3a44d40890/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationSupervisor.java#L50-L52
Yea I will remove them. I missed them - surprised findbugs or checkstyle didn't catch them!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org