You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tzolov <gi...@git.apache.org> on 2015/08/10 10:07:21 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-215: PostgreSQL complete...
GitHub user tzolov opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/198
ZEPPELIN-215: PostgreSQL completer - initial implementation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzolov/incubator-zeppelin ZEPPELIN-215
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/198.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #198
----
commit 5fb2cbc137ff859ef406e6c9ba9291fda1c30a5d
Author: tzolov <ch...@gmail.com>
Date: 2015-08-10T08:05:09Z
ZEPPELIN-215: PostgreSQL completer - initial implementation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-215: PostgreSQL complete...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/198#issuecomment-134410272
CI failure looks unrelated.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-215: PostgreSQL complete...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/198
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-215: PostgreSQL complete...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/198#issuecomment-133362004
This is ready to be reviewed and merged.
> Note that the underlying design uses pure JDBC API and will work for any JDBC driver.
Here are some of the design choices:
* The remote PSQL auto-competer uses the [JDBC Metadata](http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html) to retrieve `Schemas`, `Catalogs`, `Tables`, `Functions`, ... and `Columns` names for a configured Database connection.
* The completer data is updated on data-model update events like: `CREATE`, `DROP`, `INSERT` and alike. If you create a new table its name will appear in the suggestions list and consecutively will disappear if the table is dropped.
* Completer is provided with a static list of PSQL keywords that never change.
* Current version doesn't leverage the context. All completion suggestions are equally likely to be suggested no matter the context. This is an area for future improvements.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-215: PostgreSQL complete...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/198#issuecomment-133534082
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-215: PostgreSQL complete...
Posted by tzolov <gi...@git.apache.org>.
Github user tzolov commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/198#issuecomment-134525094
Indeed the failures was due to an unrelated CI issue.
Now the build passes and it seems good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-215: PostgreSQL complete...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/198#issuecomment-134073057
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---