You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/13 19:32:12 UTC

[GitHub] [superset] yousoph opened a new issue #12501: [SQL Lab] Split Run Button on Toolbar Missing Disabled State

yousoph opened a new issue #12501:
URL: https://github.com/apache/superset/issues/12501


   ## Screenshot
   ![image](https://user-images.githubusercontent.com/10627051/104499666-4b30af00-5592-11eb-8d4f-be78795e3528.png)
   
   ## Description
   Prereqs: Have CTAS and/or CVAS enabled on a database 
   In SQL Lab, delete all text in your query. The button should be showing a disabled state but shows as the wrong width with the text cut off. 
   
   ## Design input
   Mockup of the new disabled state for the split button would be helpful here @steejay, thank you! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] Steejay commented on issue #12501: [SQL Lab] Split Run Button on Toolbar Missing Disabled State

Posted by GitBox <gi...@apache.org>.
Steejay commented on issue #12501:
URL: https://github.com/apache/superset/issues/12501#issuecomment-765507467


   cc @yousoph @eschutho 
   
   ![Split button disabled](https://user-images.githubusercontent.com/60786102/105513467-32598500-5c87-11eb-9163-1742a8323ba5.png)
   
   link to Figma:
   https://www.figma.com/file/mPacKMIAXDpZMrQiGDeJMd/SQL-Toolbar-UX%2FUI---P0?node-id=1033%3A26744


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zuzana-vej closed issue #12501: [SQL Lab] Split Run Button on Toolbar Missing Disabled State

Posted by GitBox <gi...@apache.org>.
zuzana-vej closed issue #12501:
URL: https://github.com/apache/superset/issues/12501


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zuzana-vej commented on issue #12501: [SQL Lab] Split Run Button on Toolbar Missing Disabled State

Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #12501:
URL: https://github.com/apache/superset/issues/12501#issuecomment-822966074


   looks fixed based on linked PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org