You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "weimingdiit (via GitHub)" <gi...@apache.org> on 2023/01/30 01:51:36 UTC

[GitHub] [hudi] weimingdiit commented on a diff in pull request #7684: [HUDI-5567] Modified to make bootstrapping exception message clearer

weimingdiit commented on code in PR #7684:
URL: https://github.com/apache/hudi/pull/7684#discussion_r1090112497


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/bootstrap/HoodieSparkBootstrapSchemaProvider.java:
##########
@@ -60,7 +60,7 @@ protected Schema getBootstrapSourceSchema(HoodieEngineContext context, List<Pair
           } else if (ORC.getFileExtension().equals(extension)) {
             return getBootstrapSourceSchemaOrc(writeConfig, context, filePath);
           } else {
-            throw new HoodieException("Could not determine schema from the data files.");
+            throw new HoodieException("Could not determine schema from the data files. Only two file types, orc and parquet, are supported.");
           }

Review Comment:
   @danny0405 thanks,danny.  i have update this exception message



##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/bootstrap/HoodieSparkBootstrapSchemaProvider.java:
##########
@@ -92,7 +92,7 @@ private static Schema getBootstrapSourceSchemaOrc(HoodieWriteConfig writeConfig,
     try {
       orcReader = OrcFile.createReader(filePath, OrcFile.readerOptions(context.getHadoopConf().get()));
     } catch (IOException e) {
-      throw new HoodieException("Could not determine schema from the data files.");
+      throw new HoodieException("Could not determine schema from the data files. Create orc reader error.");
     }

Review Comment:
   @danny0405 thanks,danny.  i have update this exception message



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org