You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@chemistry.apache.org by fm...@apache.org on 2015/08/25 12:30:41 UTC

svn commit: r1697643 - in /chemistry/opencmis/trunk: chemistry-opencmis-android/chemistry-opencmis-android-client/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/ chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/...

Author: fmui
Date: Tue Aug 25 10:30:41 2015
New Revision: 1697643

URL: http://svn.apache.org/r1697643
Log:
minor improvements

Modified:
    chemistry/opencmis/trunk/chemistry-opencmis-android/chemistry-opencmis-android-client/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java
    chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/cache/impl/ContentTypeCacheLevelImpl.java
    chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java
    chemistry/opencmis/trunk/chemistry-opencmis-commons/chemistry-opencmis-commons-impl/src/main/java/org/apache/chemistry/opencmis/commons/impl/MimeHelper.java
    chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/filter/LoggingFilter.java
    chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/RepositoryInfoFrame.java

Modified: chemistry/opencmis/trunk/chemistry-opencmis-android/chemistry-opencmis-android-client/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-android/chemistry-opencmis-android-client/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java?rev=1697643&r1=1697642&r2=1697643&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-android/chemistry-opencmis-android-client/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-android/chemistry-opencmis-android-client/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java Tue Aug 25 10:30:41 2015
@@ -283,7 +283,7 @@ public class LinkCache implements Serial
                         result.append(IOUtils.encodeURL(paramValue));
                     }
 
-                    param = new StringBuilder(32);
+                    param.setLength(0);
                 } else {
                     param.append(c);
                 }

Modified: chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/cache/impl/ContentTypeCacheLevelImpl.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/cache/impl/ContentTypeCacheLevelImpl.java?rev=1697643&r1=1697642&r2=1697643&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/cache/impl/ContentTypeCacheLevelImpl.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/cache/impl/ContentTypeCacheLevelImpl.java Tue Aug 25 10:30:41 2015
@@ -81,8 +81,8 @@ public class ContentTypeCacheLevelImpl e
         // if parameters have been found, gather them
         if (parameterStart > 0) {
             SortedMap<String, String> parameter = new TreeMap<String, String>();
-            StringBuilder ksb = new StringBuilder();
-            StringBuilder vsb = new StringBuilder();
+            StringBuilder ksb = new StringBuilder(32);
+            StringBuilder vsb = new StringBuilder(32);
             boolean isKey = true;
 
             for (int i = parameterStart + 1; i < key.length(); i++) {
@@ -106,8 +106,8 @@ public class ContentTypeCacheLevelImpl e
 
                         parameter.put(ksb.toString(), vsb.toString());
 
-                        ksb = new StringBuilder();
-                        vsb = new StringBuilder();
+                        ksb.setLength(0);
+                        vsb.setLength(0);
 
                         continue;
                     } else if (c == '"') {

Modified: chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java?rev=1697643&r1=1697642&r2=1697643&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-client/chemistry-opencmis-client-bindings/src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java Tue Aug 25 10:30:41 2015
@@ -281,7 +281,7 @@ public class LinkCache implements Serial
                         result.append(IOUtils.encodeURL(paramValue));
                     }
 
-                    param = new StringBuilder(32);
+                    param.setLength(0);
                 } else {
                     param.append(c);
                 }

Modified: chemistry/opencmis/trunk/chemistry-opencmis-commons/chemistry-opencmis-commons-impl/src/main/java/org/apache/chemistry/opencmis/commons/impl/MimeHelper.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-commons/chemistry-opencmis-commons-impl/src/main/java/org/apache/chemistry/opencmis/commons/impl/MimeHelper.java?rev=1697643&r1=1697642&r2=1697643&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-commons/chemistry-opencmis-commons-impl/src/main/java/org/apache/chemistry/opencmis/commons/impl/MimeHelper.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-commons/chemistry-opencmis-commons-impl/src/main/java/org/apache/chemistry/opencmis/commons/impl/MimeHelper.java Tue Aug 25 10:30:41 2015
@@ -288,7 +288,7 @@ public final class MimeHelper {
                     }
                     authMap.put(paramName, sb.toString());
                 }
-                sb = new StringBuilder(32);
+                sb.setLength(0);
                 inQuotes = !inQuotes;
             } else if (c == '=') {
                 if (inName) {
@@ -301,7 +301,7 @@ public final class MimeHelper {
                         paramName = paramName.substring(spcIdx).trim();
                     }
 
-                    sb = new StringBuilder(32);
+                    sb.setLength(0);
                     inName = false;
                 } else if (!inQuotes) {
                     return null;
@@ -310,7 +310,7 @@ public final class MimeHelper {
                 if (inName) {
                     challenge = sb.toString().trim().toLowerCase(Locale.ENGLISH);
                     result.put(challenge, new HashMap<String, String>());
-                    sb = new StringBuilder(32);
+                    sb.setLength(0);
                 } else {
                     if (inQuotes) {
                         sb.append(c);
@@ -322,7 +322,7 @@ public final class MimeHelper {
                         if (!authMap.containsKey(paramName)) {
                             authMap.put(paramName, sb.toString().trim());
                         }
-                        sb = new StringBuilder(32);
+                        sb.setLength(0);
                         inName = true;
                     }
                 }

Modified: chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/filter/LoggingFilter.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/filter/LoggingFilter.java?rev=1697643&r1=1697642&r2=1697643&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/filter/LoggingFilter.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-server/chemistry-opencmis-server-support/src/main/java/org/apache/chemistry/opencmis/server/support/filter/LoggingFilter.java Tue Aug 25 10:30:41 2015
@@ -145,7 +145,7 @@ public class LoggingFilter implements Fi
             }
             writeTextToFile(requestFileName, xmlRequest);
 
-            sb = new StringBuilder();
+            sb.setLength(0);
             cType = logResponse.getContentType();
             String xmlResponse = logResponse.getPayload();
             String responseFileName = getResponseFileName(reqNo);

Modified: chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/RepositoryInfoFrame.java
URL: http://svn.apache.org/viewvc/chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/RepositoryInfoFrame.java?rev=1697643&r1=1697642&r2=1697643&view=diff
==============================================================================
--- chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/RepositoryInfoFrame.java (original)
+++ chemistry/opencmis/trunk/chemistry-opencmis-workbench/chemistry-opencmis-workbench/src/main/java/org/apache/chemistry/opencmis/workbench/RepositoryInfoFrame.java Tue Aug 25 10:30:41 2015
@@ -209,7 +209,7 @@ public class RepositoryInfoFrame extends
 
                 addLine("New type settable attributes:").setText(sb.toString());
 
-                sb = new StringBuilder();
+                sb = new StringBuilder(64);
                 if (cap.getCreatablePropertyTypes() != null && cap.getCreatablePropertyTypes().canCreate() != null) {
                     for (PropertyType pt : cap.getCreatablePropertyTypes().canCreate()) {
                         appendToString(sb, pt.value());