You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/06 21:53:13 UTC

[GitHub] [airflow] potiuk commented on pull request #15703: Clean up the pre-commit config

potiuk commented on pull request #15703:
URL: https://github.com/apache/airflow/pull/15703#issuecomment-833894099


   Hey @jbampton. I had to revert this change because we had problem in master. 
   
   Can you please re-do it but also add ".pre-commit-config.yaml"  to the list of files here:
   
   https://github.com/apache/airflow/blob/c61af5c3a3416aa1ad26fc3ab5c6e9a489bbbd2c/scripts/ci/selective_ci_checks.sh#L495
   
   And fix all the problems that it will uncover ? 
   
   We are running selective checks, trying to run minimal set of tests with some "small" changes, but seems that in case just ".pre-commit.yaml" was modified only sub-set of pre-commits were run and the change introduced some failures. 
   
   When you add the  config file to the "important files" list, it will trigger all tests in your PR and you will be able to see what you need to fix.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org