You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2022/10/20 21:21:00 UTC

[jira] [Commented] (MSHADE-417) Fix null bytes appended to small files by maven-shade-plugin

    [ https://issues.apache.org/jira/browse/MSHADE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17621373#comment-17621373 ] 

Hudson commented on MSHADE-417:
-------------------------------

Build succeeded in Jenkins: Maven » Maven TLP » maven-shade-plugin » master #44

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-shade-plugin/job/master/44/

> Fix null bytes appended to small files by maven-shade-plugin
> ------------------------------------------------------------
>
>                 Key: MSHADE-417
>                 URL: https://issues.apache.org/jira/browse/MSHADE-417
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>            Reporter: Max Zerzouri
>            Assignee: Guillaume Nodet
>            Priority: Major
>             Fix For: 3.4.1
>
>         Attachments: original-shadetest-0.0.0.jar, pom.xml, shadetest-0.0.0.jar, test.txt
>
>
> Version 3.3.0 of maven shade plugin seems to append "\x00" bytes to a file if it's less than 4 bytes:
> {code:sh}
> $ echo -n a > src/main/resources/test.txt
> $ mvn clean install
> ...
> $ bsdtar -xOf target/original-shadetest-0.0.0.jar test.txt | xxd
> 00000000: 61                                       a
> $ bsdtar -xOf target/shadetest-0.0.0.jar test.txt | xxd
> 00000000: 6100 0000                                a...
> {code}
> I've attached a basic {{pom.xml}} that triggers this. This doesn't occur in the previous version, 3.2.4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)