You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/11/12 04:08:20 UTC

[kudu-CR] [python] - Enable Python 3 Jenkins Build/Test 

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5059

Change subject: [python] - Enable Python 3 Jenkins Build/Test
......................................................................

[python] - Enable Python 3 Jenkins Build/Test

The current Jenkins flow only builds and executes the unit tests
for Python 2. Since Python 3 is supported we should also setup Jenkins
to build and test Python 3. This patch enables that as well as removes
the multiprocessing test dependency as that is included as a standard
library since Python 2.6.

Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
---
M build-support/jenkins/build-and-test.sh
M python/setup.py
2 files changed, 42 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/5059/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>

[kudu-CR] [python] - Enable Python 3 Jenkins Build/Test

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has submitted this change and it was merged.

Change subject: [python] - Enable Python 3 Jenkins Build/Test
......................................................................


[python] - Enable Python 3 Jenkins Build/Test

The current Jenkins flow only builds and executes the unit tests
for Python 2. Since Python 3 is supported we should also setup Jenkins
to build and test Python 3. This patch enables that as well as removes
the multiprocessing test dependency as that has been included as a standard
library since Python 2.6.

Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Reviewed-on: http://gerrit.cloudera.org:8080/5059
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M build-support/jenkins/build-and-test.sh
M python/setup.py
2 files changed, 46 insertions(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [python] - Enable Python 3 Jenkins Build/Test

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.

Change subject: [python] - Enable Python 3 Jenkins Build/Test
......................................................................


Patch Set 7:

Yep, i checked the jenkins logs, everything looked good.

-- 
To view, visit http://gerrit.cloudera.org:8080/5059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [python] - Enable Python 3 Jenkins Build/Test

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5059

to look at the new patch set (#2).

Change subject: [python] - Enable Python 3 Jenkins Build/Test
......................................................................

[python] - Enable Python 3 Jenkins Build/Test

The current Jenkins flow only builds and executes the unit tests
for Python 2. Since Python 3 is supported we should also setup Jenkins
to build and test Python 3. This patch enables that as well as removes
the multiprocessing test dependency as that is included as a standard
library since Python 2.6.

Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
---
M build-support/jenkins/build-and-test.sh
M python/setup.py
2 files changed, 42 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/5059/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [python] - Enable Python 3 Jenkins Build/Test

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5059

to look at the new patch set (#4).

Change subject: [python] - Enable Python 3 Jenkins Build/Test
......................................................................

[python] - Enable Python 3 Jenkins Build/Test

The current Jenkins flow only builds and executes the unit tests
for Python 2. Since Python 3 is supported we should also setup Jenkins
to build and test Python 3. This patch enables that as well as removes
the multiprocessing test dependency as that is included as a standard
library since Python 2.6.

Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
---
M build-support/jenkins/build-and-test.sh
M python/setup.py
2 files changed, 44 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/5059/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [python] - Enable Python 3 Jenkins Build/Test

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5059

to look at the new patch set (#3).

Change subject: [python] - Enable Python 3 Jenkins Build/Test
......................................................................

[python] - Enable Python 3 Jenkins Build/Test

The current Jenkins flow only builds and executes the unit tests
for Python 2. Since Python 3 is supported we should also setup Jenkins
to build and test Python 3. This patch enables that as well as removes
the multiprocessing test dependency as that is included as a standard
library since Python 2.6.

Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
---
M build-support/jenkins/build-and-test.sh
M python/setup.py
2 files changed, 44 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/5059/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [python] - Enable Python 3 Jenkins Build/Test

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5059

to look at the new patch set (#7).

Change subject: [python] - Enable Python 3 Jenkins Build/Test
......................................................................

[python] - Enable Python 3 Jenkins Build/Test

The current Jenkins flow only builds and executes the unit tests
for Python 2. Since Python 3 is supported we should also setup Jenkins
to build and test Python 3. This patch enables that as well as removes
the multiprocessing test dependency as that has been included as a standard
library since Python 2.6.

Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
---
M build-support/jenkins/build-and-test.sh
M python/setup.py
2 files changed, 46 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/5059/7
-- 
To view, visit http://gerrit.cloudera.org:8080/5059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [python] - Enable Python 3 Jenkins Build/Test

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5059

to look at the new patch set (#5).

Change subject: [python] - Enable Python 3 Jenkins Build/Test
......................................................................

[python] - Enable Python 3 Jenkins Build/Test

The current Jenkins flow only builds and executes the unit tests
for Python 2. Since Python 3 is supported we should also setup Jenkins
to build and test Python 3. This patch enables that as well as removes
the multiprocessing test dependency as that is included as a standard
library since Python 2.6.

Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
---
M build-support/jenkins/build-and-test.sh
M python/setup.py
2 files changed, 44 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/5059/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [python] - Enable Python 3 Jenkins Build/Test

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: [python] - Enable Python 3 Jenkins Build/Test
......................................................................


Patch Set 6:

(1 comment)

lgtm minus the nit on the comments.

Did you verify through looking at the jenkins logs that the tests are running as expected?

http://gerrit.cloudera.org:8080/#/c/5059/6/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

Line 63: #     Build and test the Python wrapper of the client API in Python 3.4.
this isn't explicitly picking python3.4, it's just whatever python3 is on the path, right?

Might be worth adding a line noting that this isn't mutually exclusive with BUILD_PYTHON and that we'll run both if they're both set.


-- 
To view, visit http://gerrit.cloudera.org:8080/5059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] [python] - Enable Python 3 Jenkins Build/Test

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: [python] - Enable Python 3 Jenkins Build/Test
......................................................................


Patch Set 7: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [python] - Enable Python 3 Jenkins Build/Test

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5059

to look at the new patch set (#6).

Change subject: [python] - Enable Python 3 Jenkins Build/Test
......................................................................

[python] - Enable Python 3 Jenkins Build/Test

The current Jenkins flow only builds and executes the unit tests
for Python 2. Since Python 3 is supported we should also setup Jenkins
to build and test Python 3. This patch enables that as well as removes
the multiprocessing test dependency as that has been included as a standard
library since Python 2.6.

Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
---
M build-support/jenkins/build-and-test.sh
M python/setup.py
2 files changed, 44 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/5059/6
-- 
To view, visit http://gerrit.cloudera.org:8080/5059
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29a15d7b877d1d5d5620bebbf945de68bfb75177
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins