You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Vincent Siveton (JIRA)" <ji...@codehaus.org> on 2008/06/28 14:46:26 UTC
[jira] Updated: (MNG-3468) FileSet needs a toString() method to
properly print in debug mode
[ http://jira.codehaus.org/browse/MNG-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vincent Siveton updated MNG-3468:
---------------------------------
Fix Version/s: 2.1-alpha-1
> FileSet needs a toString() method to properly print in debug mode
> -----------------------------------------------------------------
>
> Key: MNG-3468
> URL: http://jira.codehaus.org/browse/MNG-3468
> Project: Maven 2
> Issue Type: Improvement
> Affects Versions: 2.0.8
> Reporter: Wayne Fay
> Assignee: Brian Fox
> Fix For: 2.0.9, 2.1-alpha-1
>
> Attachments: fileset.patch
>
>
> It would be nice if FileSet had a toString() method so it would print something intelligent rather than simply a memory location in debug mode.
> Before this change, it prints like:
> FileSet@129f3b5
> With this patch, it prints like (assuming you accept my PatternSet patch):
> FileSet {directory: src/main/resources, PatternSet [includes: {}, excludes: {}]}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Updated: (MNG-3468) FileSet needs a toString() method to properly print in debug mode
Posted by Vincent Siveton <vi...@gmail.com>.
Agree with you, Paul.
Vincent
2008/6/29, Paul Benedict <pb...@apache.org>:
> I think it is very smart to always mark issues that are both 2.0.x and 2.1
> (HEAD). While it my be "common knowledge" among the depths Maven developers
> that issues being applied to 2.0.x are usually applied to trunk as well, it
> shouldn't be assumed when managing issues. It's possible for issues to be
> 2.0.x only, 2.1 only, and where they are back/forward-ported to both. I
> think it's good housekeeping to always say both to keep track of the changes
> in both branches.
>
>
> Paul
>
>
> On Sun, Jun 29, 2008 at 4:57 PM, Brett Porter <br...@apache.org> wrote:
>
> > Vincent,
> >
> > I'm a bit confused about these changes. It should be obvious that if it
> > were fixed in 2.0.9 that it is also present (if relevant) in 2.1... won't it
> > be confusing to see the 2.1 release notes and see a whole lot of things that
> > are essentially not different from the last 2.0.x releases?
> >
> > Thanks,
> > Brett
> >
> > On 28/06/2008, at 10:46 PM, Vincent Siveton (JIRA) wrote:
> >
> >
> >> [
> >> http://jira.codehaus.org/browse/MNG-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> >> ]
> >>
> >> Vincent Siveton updated MNG-3468:
> >> ---------------------------------
> >>
> >> Fix Version/s: 2.1-alpha-1
> >>
> >> FileSet needs a toString() method to properly print in debug mode
> >>> -----------------------------------------------------------------
> >>>
> >>> Key: MNG-3468
> >>> URL: http://jira.codehaus.org/browse/MNG-3468
> >>> Project: Maven 2
> >>> Issue Type: Improvement
> >>> Affects Versions: 2.0.8
> >>> Reporter: Wayne Fay
> >>> Assignee: Brian Fox
> >>> Fix For: 2.0.9, 2.1-alpha-1
> >>>
> >>> Attachments: fileset.patch
> >>>
> >>>
> >>> It would be nice if FileSet had a toString() method so it would print
> >>> something intelligent rather than simply a memory location in debug mode.
> >>> Before this change, it prints like:
> >>> FileSet@129f3b5
> >>> With this patch, it prints like (assuming you accept my PatternSet
> >>> patch):
> >>> FileSet {directory: src/main/resources, PatternSet [includes: {},
> >>> excludes: {}]}
> >>>
> >>
> >> --
> >> This message is automatically generated by JIRA.
> >> -
> >> If you think it was sent incorrectly contact one of the administrators:
> >> http://jira.codehaus.org/secure/Administrators.jspa
> >> -
> >> For more information on JIRA, see: http://www.atlassian.com/software/jira
> >>
> >>
> >>
> > --
> > Brett Porter
> > brett@apache.org
> > http://blogs.exist.com/bporter/
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] Updated: (MNG-3468) FileSet needs a toString() method to properly print in debug mode
Posted by Paul Benedict <pb...@apache.org>.
I think it is very smart to always mark issues that are both 2.0.x and 2.1
(HEAD). While it my be "common knowledge" among the depths Maven developers
that issues being applied to 2.0.x are usually applied to trunk as well, it
shouldn't be assumed when managing issues. It's possible for issues to be
2.0.x only, 2.1 only, and where they are back/forward-ported to both. I
think it's good housekeeping to always say both to keep track of the changes
in both branches.
Paul
On Sun, Jun 29, 2008 at 4:57 PM, Brett Porter <br...@apache.org> wrote:
> Vincent,
>
> I'm a bit confused about these changes. It should be obvious that if it
> were fixed in 2.0.9 that it is also present (if relevant) in 2.1... won't it
> be confusing to see the 2.1 release notes and see a whole lot of things that
> are essentially not different from the last 2.0.x releases?
>
> Thanks,
> Brett
>
> On 28/06/2008, at 10:46 PM, Vincent Siveton (JIRA) wrote:
>
>
>> [
>> http://jira.codehaus.org/browse/MNG-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Vincent Siveton updated MNG-3468:
>> ---------------------------------
>>
>> Fix Version/s: 2.1-alpha-1
>>
>> FileSet needs a toString() method to properly print in debug mode
>>> -----------------------------------------------------------------
>>>
>>> Key: MNG-3468
>>> URL: http://jira.codehaus.org/browse/MNG-3468
>>> Project: Maven 2
>>> Issue Type: Improvement
>>> Affects Versions: 2.0.8
>>> Reporter: Wayne Fay
>>> Assignee: Brian Fox
>>> Fix For: 2.0.9, 2.1-alpha-1
>>>
>>> Attachments: fileset.patch
>>>
>>>
>>> It would be nice if FileSet had a toString() method so it would print
>>> something intelligent rather than simply a memory location in debug mode.
>>> Before this change, it prints like:
>>> FileSet@129f3b5
>>> With this patch, it prints like (assuming you accept my PatternSet
>>> patch):
>>> FileSet {directory: src/main/resources, PatternSet [includes: {},
>>> excludes: {}]}
>>>
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the administrators:
>> http://jira.codehaus.org/secure/Administrators.jspa
>> -
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
> --
> Brett Porter
> brett@apache.org
> http://blogs.exist.com/bporter/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: [jira] Updated: (MNG-3468) FileSet needs a toString() method to properly print in debug mode
Posted by Vincent Siveton <vi...@gmail.com>.
Hi Brett,
2008/6/29, Brett Porter <br...@apache.org>:
> Vincent,
>
> I'm a bit confused about these changes. It should be obvious that if it
> were fixed in 2.0.9 that it is also present (if relevant) in 2.1... won't it
Since the changes have not been applied initially, it is not so obvious ;)
> be confusing to see the 2.1 release notes and see a whole lot of things that
> are essentially not different from the last 2.0.x releases?
IMHO I think it is important to specify both since we have a branch.
Some changes could be 2.0.x specific only.
I didn't remember a thread about some jira rules so maybe we need to
clarify them. Thanks to point that!
Cheers,
Vincent
> Thanks,
> Brett
>
>
> On 28/06/2008, at 10:46 PM, Vincent Siveton (JIRA) wrote:
>
>
> >
> > [
> http://jira.codehaus.org/browse/MNG-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
> >
> > Vincent Siveton updated MNG-3468:
> > ---------------------------------
> >
> > Fix Version/s: 2.1-alpha-1
> >
> >
> > > FileSet needs a toString() method to properly print in debug mode
> > >
> -----------------------------------------------------------------
> > >
> > > Key: MNG-3468
> > > URL:
> http://jira.codehaus.org/browse/MNG-3468
> > > Project: Maven 2
> > > Issue Type: Improvement
> > > Affects Versions: 2.0.8
> > > Reporter: Wayne Fay
> > > Assignee: Brian Fox
> > > Fix For: 2.0.9, 2.1-alpha-1
> > >
> > > Attachments: fileset.patch
> > >
> > >
> > > It would be nice if FileSet had a toString() method so it would print
> something intelligent rather than simply a memory location in debug mode.
> > > Before this change, it prints like:
> > > FileSet@129f3b5
> > > With this patch, it prints like (assuming you accept my PatternSet
> patch):
> > > FileSet {directory: src/main/resources, PatternSet [includes: {},
> excludes: {}]}
> > >
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > If you think it was sent incorrectly contact one of the administrators:
> http://jira.codehaus.org/secure/Administrators.jspa
> > -
> > For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >
> >
> >
>
> --
> Brett Porter
> brett@apache.org
> http://blogs.exist.com/bporter/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [jira] Updated: (MNG-3468) FileSet needs a toString() method to properly print in debug mode
Posted by Brett Porter <br...@apache.org>.
Vincent,
I'm a bit confused about these changes. It should be obvious that if
it were fixed in 2.0.9 that it is also present (if relevant) in 2.1...
won't it be confusing to see the 2.1 release notes and see a whole lot
of things that are essentially not different from the last 2.0.x
releases?
Thanks,
Brett
On 28/06/2008, at 10:46 PM, Vincent Siveton (JIRA) wrote:
>
> [ http://jira.codehaus.org/browse/MNG-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Vincent Siveton updated MNG-3468:
> ---------------------------------
>
> Fix Version/s: 2.1-alpha-1
>
>> FileSet needs a toString() method to properly print in debug mode
>> -----------------------------------------------------------------
>>
>> Key: MNG-3468
>> URL: http://jira.codehaus.org/browse/MNG-3468
>> Project: Maven 2
>> Issue Type: Improvement
>> Affects Versions: 2.0.8
>> Reporter: Wayne Fay
>> Assignee: Brian Fox
>> Fix For: 2.0.9, 2.1-alpha-1
>>
>> Attachments: fileset.patch
>>
>>
>> It would be nice if FileSet had a toString() method so it would
>> print something intelligent rather than simply a memory location in
>> debug mode.
>> Before this change, it prints like:
>> FileSet@129f3b5
>> With this patch, it prints like (assuming you accept my PatternSet
>> patch):
>> FileSet {directory: src/main/resources, PatternSet [includes: {},
>> excludes: {}]}
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the
> administrators: http://jira.codehaus.org/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org