[GitHub] [thrift] penenin commented on pull request #2121: THRIFT-5185: Add support for using WebSockets as a server transport.

[GitBox <gi...@apache.org>]

penenin commented on pull request #2121:
URL: https://github.com/apache/thrift/pull/2121#issuecomment-622597856


   I can see where that would be useful in some circumstances, but it isn't relevant for my particular project.
   
   I may have to close this PR as the code appears to work on Windows, but not on Linux. I manually tested both this implementation and the D one on Windows with a modified tutorial server and a modified nodejs client bundled for the browser with Webpack. Unfortunately, on Linux, the C++ server won't even complete the WebSocket handshake with my browser client and I can't get my modified D tutorial server to build because of a linker error. It also looks to me like the test suite is Linux only as well. I am primarily a Windows developer and I am running out of things I know to try. I will keep chipping away at it, but I am not sure how long it is going to take me to figure it out.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org