You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mahesh Reddy (Code Review)" <ge...@cloudera.org> on 2024/10/30 05:48:56 UTC

[kudu-CR](branch-1.18.x) KUDU-613: Fix minor metrics related bug

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/21992

to review the following change.


Change subject: KUDU-613: Fix minor metrics related bug
......................................................................

KUDU-613: Fix minor metrics related bug

When upserting in the protected segment, the state
of the handle isn't updated properly (the variable
in_protected_segment). This variable is used later
when releasing the handle to determine which segment's
metrics to update. This patch fixes this bug and adds
appropriate test coverage to verify the right metrics
are being updated.

Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88
Reviewed-on: http://gerrit.cloudera.org:8080/21956
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit ffc1b11f6b54f0e799146f2e444c5b001827dd31)
---
M src/kudu/util/slru_cache-test.cc
M src/kudu/util/slru_cache.cc
M src/kudu/util/slru_cache.h
3 files changed, 55 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/21992/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88
Gerrit-Change-Number: 21992
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.18.x) KUDU-613: Fix minor metrics related bug

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-613: Fix minor metrics related bug
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88
Gerrit-Change-Number: 21992
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.18.x) KUDU-613: Fix minor metrics related bug

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21992 )

Change subject: KUDU-613: Fix minor metrics related bug
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88
Gerrit-Change-Number: 21992
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Oct 2024 06:35:46 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-613: Fix minor metrics related bug

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21992 )

Change subject: KUDU-613: Fix minor metrics related bug
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/628/


-- 
To view, visit http://gerrit.cloudera.org:8080/21992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88
Gerrit-Change-Number: 21992
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Oct 2024 05:49:01 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-613: Fix minor metrics related bug

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21992 )

Change subject: KUDU-613: Fix minor metrics related bug
......................................................................


Patch Set 1: Verified+1

unrelated test failures (known flaky tests):
  * TimestampAdvancementITest.TestUpgradeFromOlderCorruptedData
  * org.apache.kudu.client.TestSecurity


-- 
To view, visit http://gerrit.cloudera.org:8080/21992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88
Gerrit-Change-Number: 21992
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Oct 2024 16:55:19 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-613: Fix minor metrics related bug

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21992 )

Change subject: KUDU-613: Fix minor metrics related bug
......................................................................

KUDU-613: Fix minor metrics related bug

When upserting in the protected segment, the state
of the handle isn't updated properly (the variable
in_protected_segment). This variable is used later
when releasing the handle to determine which segment's
metrics to update. This patch fixes this bug and adds
appropriate test coverage to verify the right metrics
are being updated.

Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88
Reviewed-on: http://gerrit.cloudera.org:8080/21956
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit ffc1b11f6b54f0e799146f2e444c5b001827dd31)
Reviewed-on: http://gerrit.cloudera.org:8080/21992
---
M src/kudu/util/slru_cache-test.cc
M src/kudu/util/slru_cache.cc
M src/kudu/util/slru_cache.h
3 files changed, 55 insertions(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88
Gerrit-Change-Number: 21992
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.18.x) KUDU-613: Fix minor metrics related bug

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21992 )

Change subject: KUDU-613: Fix minor metrics related bug
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/628/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21992
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88
Gerrit-Change-Number: 21992
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Oct 2024 06:43:37 +0000
Gerrit-HasComments: No