You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rok (via GitHub)" <gi...@apache.org> on 2026/05/05 13:59:25 UTC
[PR] GH-49923: [Parquet][Python] Inconsistent default values for Parquet pre_buffer [arrow]
rok opened a new pull request, #49924:
URL: https://github.com/apache/arrow/pull/49924
### Rationale for this change
Default `pre_buffer=True` on parquet APIs should probably be made consistent.
### What changes are included in this PR?
Couple of default parameter changes and an updated docstring.
### Are these changes tested?
By CI.
### Are there any user-facing changes?
Users will see changes to default behavior. It's hard to estimate how disruptive (if at all) this will be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49923: [Parquet][Python] Inconsistent default values for Parquet pre_buffer [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #49924:
URL: https://github.com/apache/arrow/pull/49924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49923: [Parquet][Python] Inconsistent default values for Parquet pre_buffer [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49924:
URL: https://github.com/apache/arrow/pull/49924#issuecomment-4458795352
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2a89d03bbefd620b42126b8e00f8ae57e99cd638.
There was 1 benchmark result with an error:
- Commit Run on `amd64-m5-4xlarge-linux` at [2026-05-15 03:22:48Z](https://conbench.arrow-dev.org/compare/runs/5515de1916a940db95d4722fff2d96fc...d1891ad22d774cfeb14c7572cbc55550/)
- [`file-read` (Python) with compression=uncompressed, dataset=nyctaxi_2010-01, file_type=feather, output_type=dataframe](https://conbench.arrow-dev.org/benchmark-results/06a06a363dcf7a8e80001f407514b058)
There were 6 benchmark results indicating a performance regression:
- Commit Run on `amd64-m5-4xlarge-linux` at [2026-05-15 03:22:48Z](https://conbench.arrow-dev.org/compare/runs/5515de1916a940db95d4722fff2d96fc...d1891ad22d774cfeb14c7572cbc55550/)
- [`file-read` (Python) with compression=uncompressed, dataset=nyctaxi_2010-01, file_type=feather, output_type=table](https://conbench.arrow-dev.org/compare/benchmarks/06a0699a90e470e58000e624fa49b415...06a06a247b5176db8000e6ee90f8c490)
- [`file-read` (Python) with compression=uncompressed, dataset=nyctaxi_2010-01, file_type=feather, output_type=table](https://conbench.arrow-dev.org/compare/benchmarks/06a0699a90e470e58000e624fa49b415...06a06a5e37e57e2b8000ea275286d275)
- and 4 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/76158272471) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49923: [Parquet][Python] Inconsistent default values for Parquet pre_buffer [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49924:
URL: https://github.com/apache/arrow/pull/49924#issuecomment-4389512032
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 2a89d03bbefd620b42126b8e00f8ae57e99cd638.
None of the specified runs were found on the Conbench server.
The [full Conbench report](https://github.com/apache/arrow/runs/74643852931) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49923: [Parquet][Python] Inconsistent default values for Parquet pre_buffer [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49924:
URL: https://github.com/apache/arrow/pull/49924#issuecomment-4379969356
:warning: GitHub issue #49923 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49923: [Parquet][Python] Inconsistent default values for Parquet pre_buffer [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49924:
URL: https://github.com/apache/arrow/pull/49924#issuecomment-4458850079
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2a89d03bbefd620b42126b8e00f8ae57e99cd638.
There was 1 benchmark result with an error:
- Commit Run on `amd64-m5-4xlarge-linux` at [2026-05-15 03:22:48Z](https://conbench.arrow-dev.org/compare/runs/5515de1916a940db95d4722fff2d96fc...d1891ad22d774cfeb14c7572cbc55550/)
- [`file-read` (Python) with compression=uncompressed, dataset=nyctaxi_2010-01, file_type=feather, output_type=dataframe](https://conbench.arrow-dev.org/benchmark-results/06a06a363dcf7a8e80001f407514b058)
There were 6 benchmark results indicating a performance regression:
- Commit Run on `amd64-m5-4xlarge-linux` at [2026-05-15 03:22:48Z](https://conbench.arrow-dev.org/compare/runs/5515de1916a940db95d4722fff2d96fc...d1891ad22d774cfeb14c7572cbc55550/)
- [`file-read` (Python) with compression=uncompressed, dataset=nyctaxi_2010-01, file_type=feather, output_type=table](https://conbench.arrow-dev.org/compare/benchmarks/06a0699a90e470e58000e624fa49b415...06a06a247b5176db8000e6ee90f8c490)
- [`file-read` (Python) with compression=uncompressed, dataset=nyctaxi_2010-01, file_type=feather, output_type=table](https://conbench.arrow-dev.org/compare/benchmarks/06a0699a90e470e58000e624fa49b415...06a06a5e37e57e2b8000ea275286d275)
- and 4 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/76159556905) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org