[GitHub] [trafficcontrol] mitchell852 edited a comment on pull request #4827: TP: adds first, inner and last header rewrite fields for topologies

[GitBox <gi...@apache.org>]

mitchell852 edited a comment on pull request #4827:
URL: https://github.com/apache/trafficcontrol/pull/4827#issuecomment-650378165


   > How would you feel about hiding the edge/mid header rewrite fields if they're empty and a topology is assigned? And hiding the first/inner/last header rewrite fields if they're empty and a topology isn't assigned?
   
   so i thought about this a lot actually and it gets tricky, stuff starts showing/hiding when you assign/unassign a topology and/or add/remove header rewrite rules so i came to the conclusion that maybe it's just best to show all 5 fields with an validation message that displays if you are using the wrong combination of fields. At least, I think this is a good approach which both non-topology and topology ds's are permitted. once they are not, then obviously the edge/mid header rewrite rules need to be removed entirely.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org