[GitHub] [spark] rednaxelafx commented on a change in pull request #29495: [SPARK-32640][SQL] Downgrade Janino to fix a correctness bug

[GitBox <gi...@apache.org>]

rednaxelafx commented on a change in pull request #29495:
URL: https://github.com/apache/spark/pull/29495#discussion_r474238199



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2541,6 +2541,11 @@ class DataFrameSuite extends QueryTest
       assert(df.schema === new StructType().add(StructField("d", DecimalType(38, 0))))
     }
   }
+
+  test("SPARK-32640: ln(NaN) should return NaN") {
+    val df = Seq(Double.NaN).toDF("d")
+    checkAnswer(df.selectExpr("ln(d)"), Row(Double.NaN))

Review comment:
       Question: does this actually trigger codegen? It gets converted to LocalRelation during logical optimization, right?
   (If this test fails before reverting Janino and passes after the revert, then I guess it's still valid to have it here, otherwise I'm a bit confused)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org