[jira] [Commented] (CARBONDATA-29) Make inverted index can be configurable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CARBONDATA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358856#comment-15358856 ] 

ASF GitHub Bot commented on CARBONDATA-29:
------------------------------------------

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/10#discussion_r69289069
  
    --- Diff: core/src/main/java/org/carbondata/core/datastorage/store/columnar/BlockIndexerStorageForNoInvertedIndex.java ---
    @@ -0,0 +1,134 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.carbondata.core.datastorage.store.columnar;
    +
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.carbondata.core.constants.CarbonCommonConstants;
    +import org.carbondata.core.util.ByteUtil;
    +
    +public class BlockIndexerStorageForNoInvertedIndex implements IndexStorage<int[]> {
    --- End diff --
    
    Lot of code is duplicated , Better make Abstract class and move the common code.


> Make inverted index can be configurable
> ---------------------------------------
>
>                 Key: CARBONDATA-29
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-29
>             Project: CarbonData
>          Issue Type: New Feature
>            Reporter: zhangshunyu
>
> We should make inverted index can be configurable, the user can use a parameter to open/close this function during loading data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)