You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/12/17 01:55:28 UTC
[james-project] 07/24: [Refactoring] IMAP responses: avoid super
constructor call
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 58b3e9bb5064935e71406ad2f2a0831f4784fd4d
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Fri Dec 13 07:02:48 2019 +0100
[Refactoring] IMAP responses: avoid super constructor call
They are referencing the one from Object and thus are not needed.
---
.../org/apache/james/imap/message/response/ACLResponse.java | 2 --
.../james/imap/message/response/AbstractListingResponse.java | 2 --
.../james/imap/message/response/ContinuationResponse.java | 1 -
.../apache/james/imap/message/response/ESearchResponse.java | 2 --
.../apache/james/imap/message/response/ExistsResponse.java | 1 -
.../apache/james/imap/message/response/ExpungeResponse.java | 1 -
.../org/apache/james/imap/message/response/FetchResponse.java | 11 -----------
.../james/imap/message/response/ImmutableStatusResponse.java | 5 -----
.../org/apache/james/imap/message/response/ListResponse.java | 2 --
.../james/imap/message/response/ListRightsResponse.java | 1 -
.../james/imap/message/response/MailboxStatusResponse.java | 7 -------
.../apache/james/imap/message/response/MyRightsResponse.java | 1 -
.../apache/james/imap/message/response/NamespaceResponse.java | 1 -
.../apache/james/imap/message/response/QuotaRootResponse.java | 1 -
.../apache/james/imap/message/response/RecentResponse.java | 2 --
15 files changed, 40 deletions(-)
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ACLResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ACLResponse.java
index 29c2ae2..ba41f39 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ACLResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ACLResponse.java
@@ -34,11 +34,9 @@ import org.apache.james.mailbox.model.MailboxACL.Rfc4314Rights;
*/
public final class ACLResponse implements ImapResponseMessage {
private final MailboxACL acl;
-
private final String mailboxName;
public ACLResponse(String mailboxName, MailboxACL acl) {
- super();
this.mailboxName = mailboxName;
this.acl = acl;
}
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/AbstractListingResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/AbstractListingResponse.java
index ca198dd..c50a882 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/AbstractListingResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/AbstractListingResponse.java
@@ -27,7 +27,6 @@ import org.apache.james.mailbox.model.MailboxMetaData;
import com.google.common.base.MoreObjects;
public abstract class AbstractListingResponse {
-
private final MailboxMetaData.Children children;
private final MailboxMetaData.Selectability selectability;
private final String name;
@@ -37,7 +36,6 @@ public abstract class AbstractListingResponse {
public AbstractListingResponse(MailboxMetaData.Children children,
MailboxMetaData.Selectability selectability,
String name, char hierarchyDelimiter, MailboxType type) {
- super();
this.children = children;
this.selectability = selectability;
this.name = name;
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ContinuationResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ContinuationResponse.java
index da8b5f0..8215188 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ContinuationResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ContinuationResponse.java
@@ -29,7 +29,6 @@ public class ContinuationResponse implements ImapResponseMessage {
private final HumanReadableText textKey;
public ContinuationResponse(HumanReadableText textKey) {
- super();
this.data = null;
this.textKey = textKey;
}
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ESearchResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ESearchResponse.java
index b45ac89..89e0437 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ESearchResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ESearchResponse.java
@@ -29,7 +29,6 @@ import org.apache.james.imap.api.message.response.ImapResponseMessage;
import org.apache.james.mailbox.ModSeq;
public class ESearchResponse implements ImapResponseMessage {
-
private final long minUid;
private final long maxUid;
private final long count;
@@ -41,7 +40,6 @@ public class ESearchResponse implements ImapResponseMessage {
private UidRange[] allUids;
public ESearchResponse(long minUid, long maxUid, long count, IdRange[] all, UidRange[] allUids, ModSeq highestModSeq, Tag tag, boolean useUid, List<SearchResultOption> options) {
- super();
this.options = options;
this.minUid = minUid;
this.maxUid = maxUid;
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ExistsResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ExistsResponse.java
index 18a8fca..185a200 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ExistsResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ExistsResponse.java
@@ -25,7 +25,6 @@ public final class ExistsResponse implements ImapResponseMessage {
private final long numberOfMessages;
public ExistsResponse(long numberOfMessages) {
- super();
this.numberOfMessages = numberOfMessages;
}
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ExpungeResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ExpungeResponse.java
index 323152a..2d13203 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ExpungeResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ExpungeResponse.java
@@ -26,7 +26,6 @@ public final class ExpungeResponse implements ImapResponseMessage {
private final int messageSequenceNumber;
public ExpungeResponse(int messageSequenceNumber) {
- super();
this.messageSequenceNumber = messageSequenceNumber;
}
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/FetchResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/FetchResponse.java
index aaa5cc1..0d64091 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/FetchResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/FetchResponse.java
@@ -30,29 +30,18 @@ import org.apache.james.mailbox.MessageUid;
import org.apache.james.mailbox.ModSeq;
public final class FetchResponse implements ImapResponseMessage {
-
private final int messageNumber;
-
private final Flags flags;
-
private final MessageUid uid;
-
private final Date internalDate;
-
private final Long size;
-
private final List<BodyElement> elements;
-
private final Envelope envelope;
-
private final Structure body;
-
private final Structure bodystructure;
-
private final ModSeq modSeq;
public FetchResponse(int messageNumber, Flags flags, MessageUid uid, ModSeq modSeq, Date internalDate, Long size, Envelope envelope, Structure body, Structure bodystructure, List<BodyElement> elements) {
- super();
this.messageNumber = messageNumber;
this.flags = flags;
this.uid = uid;
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ImmutableStatusResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ImmutableStatusResponse.java
index e502348..df67936 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ImmutableStatusResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ImmutableStatusResponse.java
@@ -30,15 +30,10 @@ import com.google.common.base.MoreObjects;
* Immutable status response. Suitable for unpooled usage.
*/
public class ImmutableStatusResponse implements StatusResponse {
-
private final ResponseCode responseCode;
-
private final Type serverResponseType;
-
private final Tag tag;
-
private final HumanReadableText textKey;
-
private final ImapCommand command;
public ImmutableStatusResponse(Type serverResponseType, Tag tag, ImapCommand command, HumanReadableText textKey, ResponseCode responseCode) {
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ListResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ListResponse.java
index 62efa61..cde9f35 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ListResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ListResponse.java
@@ -26,9 +26,7 @@ import org.apache.james.mailbox.model.MailboxMetaData;
* Values an IMAP4rev1 <code>LIST</code> response.
*/
public final class ListResponse extends AbstractListingResponse implements ImapResponseMessage {
-
public ListResponse(MailboxMetaData.Children children, MailboxMetaData.Selectability selectability, String name, char hierarchyDelimiter) {
super(children, selectability, name, hierarchyDelimiter, MailboxType.OTHER);
}
-
}
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ListRightsResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ListRightsResponse.java
index 970491d..5bba8a8 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ListRightsResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ListRightsResponse.java
@@ -30,7 +30,6 @@ import org.apache.james.mailbox.model.MailboxACL;
* LISTRIGHTS Response.
*/
public final class ListRightsResponse implements ImapResponseMessage {
-
private final String identifier;
private final String mailboxName;
private final MailboxACL.Rfc4314Rights[] rights;
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/MailboxStatusResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/MailboxStatusResponse.java
index 9608625..c7798b3 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/MailboxStatusResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/MailboxStatusResponse.java
@@ -27,19 +27,12 @@ import org.apache.james.mailbox.ModSeq;
* Represents a <code>STATUS</code> response. See <code>RFC3501 7.2.4</code>.
*/
public class MailboxStatusResponse implements ImapResponseMessage {
-
private final Long messages;
-
private final Long recent;
-
private final MessageUid uidNext;
-
private final Long uidValidity;
-
private final Long unseen;
-
private final String mailbox;
-
private final ModSeq highestModSeq;
public MailboxStatusResponse(Long messages, Long recent, MessageUid uidNext, ModSeq highestModSeq, Long uidValidity, Long unseen, String mailbox) {
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/MyRightsResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/MyRightsResponse.java
index 2468cdc..10628f0 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/MyRightsResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/MyRightsResponse.java
@@ -33,7 +33,6 @@ public final class MyRightsResponse implements ImapResponseMessage {
private final MailboxACL.Rfc4314Rights myRights;
public MyRightsResponse(String mailboxName, MailboxACL.Rfc4314Rights myRights) {
- super();
this.mailboxName = mailboxName;
this.myRights = myRights;
}
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/NamespaceResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/NamespaceResponse.java
index 92191f9..6c20bd0 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/NamespaceResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/NamespaceResponse.java
@@ -27,7 +27,6 @@ import org.apache.james.imap.api.message.response.ImapResponseMessage;
* Describes a NAMESPACE response.
*/
public class NamespaceResponse implements ImapResponseMessage {
-
private final List<Namespace> personal;
private final List<Namespace> users;
private final List<Namespace> shared;
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/QuotaRootResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/QuotaRootResponse.java
index 8ed9498..a4bb28f 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/QuotaRootResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/QuotaRootResponse.java
@@ -30,7 +30,6 @@ public class QuotaRootResponse implements ImapResponseMessage {
private final String mailboxName;
public QuotaRootResponse(String mailboxName, String quotaRoot) {
- super();
this.mailboxName = mailboxName;
this.quotaRoot = quotaRoot;
}
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/RecentResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/RecentResponse.java
index 8725e40..43b42c8 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/RecentResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/RecentResponse.java
@@ -22,11 +22,9 @@ package org.apache.james.imap.message.response;
import org.apache.james.imap.api.message.response.ImapResponseMessage;
public final class RecentResponse implements ImapResponseMessage {
-
private final int numberFlaggedRecent;
public RecentResponse(int numberFlaggedRecent) {
- super();
this.numberFlaggedRecent = numberFlaggedRecent;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org