You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2025/11/01 21:05:00 UTC

svn commit: r1929468 - pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font

Author: tilman
Date: Sat Nov  1 21:04:59 2025
New Revision: 1929468

Log:
PDFBOX-5660: close input, as suggested by Valery Bokov; refactor; closes #307

Modified:
   pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java	Sat Nov  1 18:02:33 2025	(r1929467)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/font/PDFontTest.java	Sat Nov  1 21:04:59 2025	(r1929468)
@@ -84,7 +84,8 @@ class PDFontTest
     void testPDFBox988() throws IOException
     {
         try (PDDocument doc = 
-                Loader.loadPDF(new RandomAccessReadBuffer(PDFontTest.class.getResourceAsStream("F001u_3_7j.pdf"))))
+                Loader.loadPDF(RandomAccessReadBuffer.createBufferFromStream(
+                        PDFontTest.class.getResourceAsStream("F001u_3_7j.pdf"))))
         {
             PDFRenderer renderer = new PDFRenderer(doc);
             renderer.renderImage(0);
@@ -184,9 +185,10 @@ class PDFontTest
         try (PDDocument doc = new PDDocument())
         {
             PDPage page = new PDPage();
-            try (PDPageContentStream contentStream = new PDPageContentStream(doc, page))
+            try (PDPageContentStream contentStream = new PDPageContentStream(doc, page);
+                 InputStream is = new FileInputStream(fontFile))
             {
-                PDType1Font font = new PDType1Font(doc, new FileInputStream(fontFile), WinAnsiEncoding.INSTANCE);
+                PDType1Font font = new PDType1Font(doc, is, WinAnsiEncoding.INSTANCE);
 
                 contentStream.beginText();
                 contentStream.setFont(font, 10);