You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/11/28 21:38:18 UTC

[GitHub] dubee commented on a change in pull request #388: Save Code Associated with Blackbox Actions

dubee commented on a change in pull request #388: Save Code Associated with Blackbox Actions
URL: https://github.com/apache/incubator-openwhisk-cli/pull/388#discussion_r237270989
 
 

 ##########
 File path: commands/action.go
 ##########
 @@ -692,7 +692,7 @@ func saveCode(action whisk.Action, filename string) (err error) {
 	exec = *action.Exec
 	runtime = strings.Split(exec.Kind, ":")[0]
 
-	if strings.ToLower(runtime) == BLACKBOX {
+	if strings.ToLower(runtime) == BLACKBOX && exec.Code == nil && *exec.Binary == false {
 
 Review comment:
   Yes, the binary field should always have a value. @mdeuser 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services