You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/08/06 22:44:07 UTC

[GitHub] [samza] MabelYC commented on a change in pull request #1408: SAMZA-2574: improve flexibility of SystemFactory interface

MabelYC commented on a change in pull request #1408:
URL: https://github.com/apache/samza/pull/1408#discussion_r466724607



##########
File path: samza-api/src/main/java/org/apache/samza/system/SystemFactory.java
##########
@@ -32,4 +32,16 @@
   SystemProducer getProducer(String systemName, Config config, MetricsRegistry registry);
 
   SystemAdmin getAdmin(String systemName, Config config);
+
+  default SystemConsumer getConsumer(String systemName, Config config, MetricsRegistry registry, String consumerIdPrefix) {

Review comment:
       by "add some documentation" you mean add  javadoc or open source documentation?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org