You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/10/23 11:27:48 UTC
Review Request 27069: Admin View: description is being variable
replaced
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27069/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko and Andrii Tkach.
Bugs: ambari-7916
https://issues.apache.org/jira/browse/ambari-7916
Repository: ambari
Description
-------
On instance create, when loading a instance parameter description that includes text that looks a variable (for example {username}), the username is being replaced.
This can be seen with the Slider View and the slider.user parameter description.
Note: I only see this during create view instance. Edit view instance parameters does not seem to do the replace of the description string.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js 68421fa
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/ambariViews/CreateViewInstanceCtrl_test.js 4deaf52
Diff: https://reviews.apache.org/r/27069/diff/
Testing
-------
Thanks,
Oleg Nechiporenko
Re: Review Request 27069: Admin View: description is being variable
replaced
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27069/#review57972
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On Oct. 23, 2014, 9:27 a.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27069/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 9:27 a.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Andrii Tkach.
>
>
> Bugs: ambari-7916
> https://issues.apache.org/jira/browse/ambari-7916
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On instance create, when loading a instance parameter description that includes text that looks a variable (for example {username}), the username is being replaced.
> This can be seen with the Slider View and the slider.user parameter description.
> Note: I only see this during create view instance. Edit view instance parameters does not seem to do the replace of the description string.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js 68421fa
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/ambariViews/CreateViewInstanceCtrl_test.js 4deaf52
>
> Diff: https://reviews.apache.org/r/27069/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 27069: Admin View: description is being variable
replaced
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27069/#review57971
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Жов. 23, 2014, 9:27 до полудня, Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27069/
> -----------------------------------------------------------
>
> (Updated Жов. 23, 2014, 9:27 до полудня)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Andrii Tkach.
>
>
> Bugs: ambari-7916
> https://issues.apache.org/jira/browse/ambari-7916
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On instance create, when loading a instance parameter description that includes text that looks a variable (for example {username}), the username is being replaced.
> This can be seen with the Slider View and the slider.user parameter description.
> Note: I only see this during create view instance. Edit view instance parameters does not seem to do the replace of the description string.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js 68421fa
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/ambariViews/CreateViewInstanceCtrl_test.js 4deaf52
>
> Diff: https://reviews.apache.org/r/27069/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>