You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2012/02/22 15:18:31 UTC

svn commit: r1292302 - /myfaces/tobago/trunk/tobago-example/tobago-example-test/src/main/webapp/script/tobago-assert.js

Author: lofwyr
Date: Wed Feb 22 14:18:30 2012
New Revision: 1292302

URL: http://svn.apache.org/viewvc?rev=1292302&view=rev
Log:
better computation of position with jQuery

Modified:
    myfaces/tobago/trunk/tobago-example/tobago-example-test/src/main/webapp/script/tobago-assert.js

Modified: myfaces/tobago/trunk/tobago-example/tobago-example-test/src/main/webapp/script/tobago-assert.js
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-example/tobago-example-test/src/main/webapp/script/tobago-assert.js?rev=1292302&r1=1292301&r2=1292302&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-example/tobago-example-test/src/main/webapp/script/tobago-assert.js (original)
+++ myfaces/tobago/trunk/tobago-example/tobago-example-test/src/main/webapp/script/tobago-assert.js Wed Feb 22 14:18:30 2012
@@ -22,13 +22,8 @@
 var TobagoAssert = {
 
   assertLeft: function(elementOrId, left) {
-    var element = TobagoAssert.jQueryElement(elementOrId).get(0);
-    var offsetLeft = element.offsetLeft;
-    var parent = element;
-    while (parent.offsetParent != null) {
-      parent = parent.offsetParent;
-      offsetLeft += parent.offsetLeft;
-    }
+    var element = TobagoAssert.jQueryElement(elementOrId);
+    var offsetLeft = element.offset().left;
     if (offsetLeft != left) {
       LOG.error("The element '" + element.tagName + "' with id='" + element.id + "' has wrong left: expected=" + left
           + " actual=" + offsetLeft);
@@ -36,13 +31,8 @@ var TobagoAssert = {
   },
 
   assertTop: function(elementOrId, top) {
-    var element = TobagoAssert.jQueryElement(elementOrId).get(0);
-    var offsetTop = element.offsetTop;
-    var parent = element;
-    while (parent.offsetParent != null) {
-      parent = parent.offsetParent;
-      offsetTop += parent.offsetTop;
-    }
+    var element = TobagoAssert.jQueryElement(elementOrId);
+    var offsetTop = element.offset().top;
     if (offsetTop != top) {
       LOG.error("The element '" + element.tagName + "' with id='" + element.id + "' has wrong top: expected=" + top
           + " actual=" + offsetTop);