You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/09/28 21:32:34 UTC
[GitHub] [ignite] raymondpwilson opened a new pull request #9443: IGNITE-15602 Define and use a discovery port in the KubernetesConnect…
raymondpwilson opened a new pull request #9443:
URL: https://github.com/apache/ignite/pull/9443
…ionConfiguration for use by the TcpDiscoveryKubernetesIpFinder
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn merged pull request #9443: IGNITE-15602 Add KubernetesConnectionConfiguration.discoveryPort
Posted by GitBox <gi...@apache.org>.
ptupitsyn merged pull request #9443:
URL: https://github.com/apache/ignite/pull/9443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] raymondpwilson commented on a change in pull request #9443: IGNITE-15602 Define and use a discovery port in the KubernetesConnect…
Posted by GitBox <gi...@apache.org>.
raymondpwilson commented on a change in pull request #9443:
URL: https://github.com/apache/ignite/pull/9443#discussion_r719145509
##########
File path: modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/configuration/KubernetesConnectionConfiguration.java
##########
@@ -138,6 +141,24 @@ public boolean getIncludeNotReadyAddresses() {
return includeNotReadyAddresses;
}
+ /**
+ * Specifies the port which is returned to the caller to use for service discovery
+ * defaults to 0
+ * @param discoveryPort Port to use for Kubernetes IP Finder
Review comment:
Have merged all suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #9443: IGNITE-15602 Define and use a discovery port in the KubernetesConnect…
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #9443:
URL: https://github.com/apache/ignite/pull/9443#discussion_r719117647
##########
File path: modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/configuration/KubernetesConnectionConfiguration.java
##########
@@ -138,6 +141,24 @@ public boolean getIncludeNotReadyAddresses() {
return includeNotReadyAddresses;
}
+ /**
+ * Specifies the port which is returned to the caller to use for service discovery
Review comment:
```suggestion
* Specifies the port which is returned to the caller to use for service discovery.
```
##########
File path: modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/configuration/KubernetesConnectionConfiguration.java
##########
@@ -138,6 +141,24 @@ public boolean getIncludeNotReadyAddresses() {
return includeNotReadyAddresses;
}
+ /**
+ * Specifies the port which is returned to the caller to use for service discovery
+ * defaults to 0
+ * @param discoveryPort Port to use for Kubernetes IP Finder
Review comment:
```suggestion
* @param discoveryPort Port to use for Kubernetes IP Finder.
```
##########
File path: modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/configuration/KubernetesConnectionConfiguration.java
##########
@@ -138,6 +141,24 @@ public boolean getIncludeNotReadyAddresses() {
return includeNotReadyAddresses;
}
+ /**
+ * Specifies the port which is returned to the caller to use for service discovery
+ * defaults to 0
+ * @param discoveryPort Port to use for Kubernetes IP Finder
+ * @return {@code this} for chaining.
+ */
+ public KubernetesConnectionConfiguration setDiscoveryPort(int discoveryPort) {
+ this.discoveryPort = discoveryPort;
Review comment:
```suggestion
this.discoveryPort = discoveryPort;
```
##########
File path: modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/configuration/KubernetesConnectionConfiguration.java
##########
@@ -138,6 +141,24 @@ public boolean getIncludeNotReadyAddresses() {
return includeNotReadyAddresses;
}
+ /**
+ * Specifies the port which is returned to the caller to use for service discovery
+ * defaults to 0
Review comment:
```suggestion
* Defaults to 0.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] timoninmaxim commented on a change in pull request #9443: IGNITE-15602 Define and use a discovery port in the KubernetesConnect…
Posted by GitBox <gi...@apache.org>.
timoninmaxim commented on a change in pull request #9443:
URL: https://github.com/apache/ignite/pull/9443#discussion_r719102954
##########
File path: modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/configuration/KubernetesConnectionConfiguration.java
##########
@@ -138,6 +141,24 @@ public boolean getIncludeNotReadyAddresses() {
return includeNotReadyAddresses;
}
+ /**
+ * Specifies the port which is returned to the caller to use for service discovery
+ * defaults to 0
+ * @param discoveryPort Port to use for Kubernetes IP Finder
+ * @return {@code this} for chaining.
+ */
+ public KubernetesConnectionConfiguration setDiscoveryPort(int discoveryPort) {
+ this.discoveryPort = discoveryPort;
+ return this;
Review comment:
Hi! Could you please align formatting with other public methods:
1. You should put a point in end of lines in all comments.
2. Add additional new line before `@param` and `return`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] raymondpwilson commented on a change in pull request #9443: IGNITE-15602 Define and use a discovery port in the KubernetesConnect…
Posted by GitBox <gi...@apache.org>.
raymondpwilson commented on a change in pull request #9443:
URL: https://github.com/apache/ignite/pull/9443#discussion_r719145008
##########
File path: modules/kubernetes/src/main/java/org/apache/ignite/kubernetes/configuration/KubernetesConnectionConfiguration.java
##########
@@ -138,6 +141,24 @@ public boolean getIncludeNotReadyAddresses() {
return includeNotReadyAddresses;
}
+ /**
+ * Specifies the port which is returned to the caller to use for service discovery
+ * defaults to 0
+ * @param discoveryPort Port to use for Kubernetes IP Finder
+ * @return {@code this} for chaining.
+ */
+ public KubernetesConnectionConfiguration setDiscoveryPort(int discoveryPort) {
+ this.discoveryPort = discoveryPort;
+ return this;
Review comment:
Done, via Pavel's suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org