You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/09/18 11:54:31 UTC

[PR] fix(desktop): restore module-page content alignment [maka]

liuxiaocs7 opened a new pull request, #5486:
URL: https://github.com/apache/maka/pull/5486

   ## Summary
   
   Restore the shared Desktop module-page body to Astryx's centered `contentWidth` lane after the 0.6.1 upgrade changed `padding={0}` to full-bleed geometry.
   
   `ModulePage` now lets `LayoutContent` own the content-width gutters, while the module panel keeps only its vertical padding. Storybook geometry assertions cover Skills, MCP, Scheduled Tasks, Daily Review, and wide inspector states.
   
   Fixes #5485
   
   ### Before / after
   
   | Skills before | Skills after |
   | --- | --- |
   | ![Skills rows escaping the header lane](https://raw.githubusercontent.com/liuxiaocs7/maka/fix/module-page-content-lane/docs/images/pr/module-page-content-lane/skills-before.png) | ![Skills rows aligned with the header lane](https://raw.githubusercontent.com/liuxiaocs7/maka/fix/module-page-content-lane/docs/images/pr/module-page-content-lane/skills-after.png) |
   
   | Scheduled Tasks before | Scheduled Tasks after |
   | --- | --- |
   | ![Scheduled-task rows escaping the header lane](https://raw.githubusercontent.com/liuxiaocs7/maka/fix/module-page-content-lane/docs/images/pr/module-page-content-lane/scheduled-tasks-before.png) | ![Scheduled-task rows aligned with the header lane](https://raw.githubusercontent.com/liuxiaocs7/maka/fix/module-page-content-lane/docs/images/pr/module-page-content-lane/scheduled-tasks-after.png) |
   
   ## Verification
   
   - `npm run lint`
   - `npm run format:check`
   - `npm run build`
   - `npm run typecheck`
   - `npx knip --workspace apps/desktop`
   - `npx knip --workspace packages/ui`
   - `npm --workspace @maka/desktop run typecheck:stories`
   - `npm --workspace @maka/desktop run build-storybook`
   - `npm --workspace @maka/desktop run smoke:storybook` — 380 stories / 412 theme renders
   - `node --test scripts/storybook-visual-smoke.test.mjs`
   - `npm run check:asf-headers`
   - `git diff --check`
   
   The new geometry assertion fails against the previous implementation with a 188–208 px body/header offset and passes after the fix.
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Codex diagnosed the Astryx layout regression, implemented the component/CSS fix, added Storybook geometry coverage, captured screenshots, and ran validation. The commit includes the required `Generated-by: Codex` trailer.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(desktop): restore module-page content alignment [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #5486:
URL: https://github.com/apache/maka/pull/5486


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org