[GitHub] spark pull request #22848: [SPARK-25851][SQL][MINOR] Fix deprecated API warn...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22848#discussion_r228553964
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala ---
    @@ -89,12 +89,12 @@ private class LongLongTupleConverter extends Converter[(Object, Object), (Long,
       }
     
       override def getInputType(typeFactory: TypeFactory): JavaType = {
    -    val objectType = typeFactory.uncheckedSimpleType(classOf[Object])
    -    typeFactory.constructSimpleType(classOf[(_, _)], classOf[(_, _)], Array(objectType, objectType))
    +    val objectType = typeFactory.constructType(classOf[Object])
    +    typeFactory.constructSimpleType(classOf[(_, _)], Array(objectType, objectType))
       }
     
       override def getOutputType(typeFactory: TypeFactory): JavaType = {
    -    val longType = typeFactory.uncheckedSimpleType(classOf[Long])
    -    typeFactory.constructSimpleType(classOf[(_, _)], classOf[(_, _)], Array(longType, longType))
    +    val longType = typeFactory.constructType(classOf[(Long)])
    --- End diff --
    
    Are the parentheses around `Long` needed?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org