You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "fuchanghai (via GitHub)" <gi...@apache.org> on 2023/05/19 07:18:39 UTC

[GitHub] [dolphinscheduler] fuchanghai commented on a diff in pull request #14147: [Improvement-14146][K8S Task] print complete error logs in task log file

fuchanghai commented on code in PR #14147:
URL: https://github.com/apache/dolphinscheduler/pull/14147#discussion_r1198628729


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/AbstractK8sTask.java:
##########
@@ -48,8 +48,9 @@ public void handle(TaskCallBack taskCallBack) throws TaskException {
             setExitStatusCode(response.getExitStatusCode());
             setAppIds(response.getAppIds());
         } catch (Exception e) {
+            log.error("k8s task submit failed with error", e);
             exitStatusCode = -1;
-            throw new TaskException("k8s process failure", e);
+            throw new TaskException("Execute k8s task error", e);

Review Comment:
   hi @Radeity  do you need lowercase ```Execute```?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org