You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/09/17 10:56:45 UTC
[PR] [ISSUE #4515] fix(alert): block stale rule actions while filtering [rocketmq-dashboard]
Aias00 opened a new pull request, #4518:
URL: https://github.com/apache/rocketmq-dashboard/pull/4518
## Summary
- re-enter the Alert Rules table loading state whenever the server-backed query refreshes
- block row selection, row mutations, and bulk mutations while replacement rows are pending
- add a deferred filter regression that keeps old rows visible but verifies every stale mutation path is disabled
## Validation
- `npm test -- src/pages/ops/__tests__/AlertsPage.test.tsx --silent` (27/27)
- `npm test -- --retry=2 --reporter=dot --silent` (122 files, 1035/1035)
- `npm run lint` (0 errors; 10 pre-existing warnings)
- `npm run build`
- `npx prettier --check src/pages/ops/alerts.tsx src/pages/ops/__tests__/AlertsPage.test.tsx`
- `git diff --check`
- independent code review: APPROVE after the stale bulk-action guard was added
Closes #4515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #4515] fix(alert): block stale rule actions while filtering [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #4518: [ISSUE #4515] fix(alert): block stale rule actions while filtering
URL: https://github.com/apache/rocketmq-dashboard/pull/4518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #4515] fix(alert): block stale rule actions while filtering [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #4518:
URL: https://github.com/apache/rocketmq-dashboard/pull/4518#issuecomment-5759709322
Superseded by the consolidated loading-state fix in #4527, which now includes this alert-rule change on top of the current `rocketmq-studio` branch together with the ACL and system-alert variants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org