You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/10/18 20:34:56 UTC
[Impala-ASF-CR](hadoop-next) IMPALA-4277: don't use deprecated s3:// filesystem
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4748
Change subject: IMPALA-4277: don't use deprecated s3:// filesystem
......................................................................
IMPALA-4277: don't use deprecated s3:// filesystem
Support was removed in Hadoop 3.0 by HADOOP-12709
Change-Id: Ibfadd2bc91c7dbcb6f2bc962c404caea30f9b776
---
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/4748/1
--
To view, visit http://gerrit.cloudera.org:8080/4748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibfadd2bc91c7dbcb6f2bc962c404caea30f9b776
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: hadoop-next
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](hadoop-next) IMPALA-4277: remove references for unsupported s3/s3n connectors
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4748/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:
PS1, Line 34: import org.apache.hadoop.fs.s3native.NativeS3FileSystem;
> Can remove
Done
PS1, Line 282: NativeS3FileSystem
> We don't support Native (s3n) as well. So we can remove that too.
Done
--
To view, visit http://gerrit.cloudera.org:8080/4748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfadd2bc91c7dbcb6f2bc962c404caea30f9b776
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: hadoop-next
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR](hadoop-next) IMPALA-4277: remove references for unsupported s3/s3n connectors
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors
......................................................................
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfadd2bc91c7dbcb6f2bc962c404caea30f9b776
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: hadoop-next
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR](hadoop-next) IMPALA-4277: remove references for unsupported s3/s3n connectors
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4748
to look at the new patch set (#2).
Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors
......................................................................
IMPALA-4277: remove references for unsupported s3/s3n connectors
We only support s3a://.
Support will be removed for s3:// in Hadoop 3.0 by HADOOP-12709
Change-Id: Ibfadd2bc91c7dbcb6f2bc962c404caea30f9b776
---
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/4748/2
--
To view, visit http://gerrit.cloudera.org:8080/4748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibfadd2bc91c7dbcb6f2bc962c404caea30f9b776
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: hadoop-next
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR](hadoop-next) IMPALA-4277: remove references for unsupported s3/s3n connectors
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged.
Change subject: IMPALA-4277: remove references for unsupported s3/s3n connectors
......................................................................
IMPALA-4277: remove references for unsupported s3/s3n connectors
We only support s3a://.
Support will be removed for s3:// in Hadoop 3.0 by HADOOP-12709
Change-Id: Ibfadd2bc91c7dbcb6f2bc962c404caea30f9b776
Reviewed-on: http://gerrit.cloudera.org:8080/4748
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/4748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfadd2bc91c7dbcb6f2bc962c404caea30f9b776
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: hadoop-next
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](hadoop-next) IMPALA-4277: don't use deprecated s3:// filesystem
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4277: don't use deprecated s3:// filesystem
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4748/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:
PS1, Line 34: import org.apache.hadoop.fs.s3native.NativeS3FileSystem;
Can remove
PS1, Line 282: NativeS3FileSystem
We don't support Native (s3n) as well. So we can remove that too.
--
To view, visit http://gerrit.cloudera.org:8080/4748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfadd2bc91c7dbcb6f2bc962c404caea30f9b776
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: hadoop-next
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes