You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/08/22 11:37:56 UTC
[GitHub] [hadoop] myhonor2013 opened a new pull request #2238: YARN-8746. fix overview in ui2 doesn't display GPU usage info when using Fairscheduler
myhonor2013 opened a new pull request #2238:
URL: https://github.com/apache/hadoop/pull/2238
see https://issues.apache.org/jira/browse/YARN-8746
When using fair scheduler, GPU related information isn't displayed because the "metrics" api doesn't return any GPU related usage information( has run yarn on GPU per [this |https://hadoop.apache.org/docs/r3.1.1/hadoop-yarn/hadoop-yarn-site/UsingGpus.html).] The hadoop versions after 3.1.1 are all affected
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] myhonor2013 commented on a change in pull request #2238: YARN-8746. fix overview in ui2 doesn't display GPU usage info when using Fairscheduler
Posted by GitBox <gi...@apache.org>.
myhonor2013 commented on a change in pull request #2238:
URL: https://github.com/apache/hadoop/pull/2238#discussion_r475297726
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
##########
@@ -134,6 +135,11 @@ public ClusterMetricsInfo(final ResourceScheduler rs) {
this.totalMB = availableMB + allocatedMB;
this.totalVirtualCores = availableVirtualCores + allocatedVirtualCores;
}
+ if (rs instanceof FairScheduler) {
+ FairScheduler fs = (FairScheduler) rs;
+ totalUsedResourcesAcrossPartition = new ResourceInfo(fs.getQueueManager().getRootQueue().getResourceUsage());
+ totalClusterResourcesAcrossPartition = new ResourceInfo(fs.getClusterResource());
+ }
Review comment:
It seems we also need to add the snippet below to the FairScheduler conditional branch if we move the code segment to else if clause. I'm not sure which is "_less ugly_". Do you have any suggestion on this?
```
this.totalMB = availableMB + allocatedMB;
this.totalVirtualCores = availableVirtualCores + allocatedVirtualCores;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] myhonor2013 commented on a change in pull request #2238: YARN-8746. fix overview in ui2 doesn't display GPU usage info when using Fairscheduler
Posted by GitBox <gi...@apache.org>.
myhonor2013 commented on a change in pull request #2238:
URL: https://github.com/apache/hadoop/pull/2238#discussion_r475297726
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
##########
@@ -134,6 +135,11 @@ public ClusterMetricsInfo(final ResourceScheduler rs) {
this.totalMB = availableMB + allocatedMB;
this.totalVirtualCores = availableVirtualCores + allocatedVirtualCores;
}
+ if (rs instanceof FairScheduler) {
+ FairScheduler fs = (FairScheduler) rs;
+ totalUsedResourcesAcrossPartition = new ResourceInfo(fs.getQueueManager().getRootQueue().getResourceUsage());
+ totalClusterResourcesAcrossPartition = new ResourceInfo(fs.getClusterResource());
+ }
Review comment:
It seems we also need to add the snippet below to the FairScheduler conditional branch if we move the code segment to else if clause
`
this.totalMB = availableMB + allocatedMB;
this.totalVirtualCores = availableVirtualCores + allocatedVirtualCores;
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2238: YARN-8746. fix overview in ui2 doesn't display GPU usage info when using Fairscheduler
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2238:
URL: https://github.com/apache/hadoop/pull/2238#issuecomment-678646929
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 28m 20s | trunk passed |
| +1 :green_heart: | compile | 0m 56s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | compile | 0m 49s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | checkstyle | 0m 41s | trunk passed |
| +1 :green_heart: | mvnsite | 0m 55s | trunk passed |
| +1 :green_heart: | shadedclient | 15m 30s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 42s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 0m 36s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +0 :ok: | spotbugs | 1m 42s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 40s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 49s | the patch passed |
| +1 :green_heart: | compile | 0m 49s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javac | 0m 49s | the patch passed |
| +1 :green_heart: | compile | 0m 41s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | javac | 0m 41s | the patch passed |
| -0 :warning: | checkstyle | 0m 31s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 45s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 13m 45s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 0m 32s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | findbugs | 1m 43s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 89m 32s | hadoop-yarn-server-resourcemanager in the patch passed. |
| +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. |
| | | 162m 32s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2238/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2238 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 4f35df130184 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f734455e5d7 |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2238/1/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2238/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2238/1/testReport/ |
| Max. process+thread count | 882 (vs. ulimit of 5500) |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2238/1/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] jiwq commented on a change in pull request #2238: YARN-8746. fix overview in ui2 doesn't display GPU usage info when using Fairscheduler
Posted by GitBox <gi...@apache.org>.
jiwq commented on a change in pull request #2238:
URL: https://github.com/apache/hadoop/pull/2238#discussion_r475222031
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
##########
@@ -134,6 +135,11 @@ public ClusterMetricsInfo(final ResourceScheduler rs) {
this.totalMB = availableMB + allocatedMB;
this.totalVirtualCores = availableVirtualCores + allocatedVirtualCores;
}
+ if (rs instanceof FairScheduler) {
+ FairScheduler fs = (FairScheduler) rs;
+ totalUsedResourcesAcrossPartition = new ResourceInfo(fs.getQueueManager().getRootQueue().getResourceUsage());
+ totalClusterResourcesAcrossPartition = new ResourceInfo(fs.getClusterResource());
+ }
Review comment:
I suggest move this code segment to `else if`. Such as:
```suggestion
} else if (rs instanceof FairScheduler) {
FairScheduler fs = (FairScheduler) rs;
totalUsedResourcesAcrossPartition = new ResourceInfo(fs.getQueueManager().getRootQueue().getResourceUsage());
totalClusterResourcesAcrossPartition = new ResourceInfo(fs.getClusterResource());
} else {
this.totalMB = availableMB + allocatedMB;
this.totalVirtualCores = availableVirtualCores + allocatedVirtualCores;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] myhonor2013 commented on a change in pull request #2238: YARN-8746. fix overview in ui2 doesn't display GPU usage info when using Fairscheduler
Posted by GitBox <gi...@apache.org>.
myhonor2013 commented on a change in pull request #2238:
URL: https://github.com/apache/hadoop/pull/2238#discussion_r475297726
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ClusterMetricsInfo.java
##########
@@ -134,6 +135,11 @@ public ClusterMetricsInfo(final ResourceScheduler rs) {
this.totalMB = availableMB + allocatedMB;
this.totalVirtualCores = availableVirtualCores + allocatedVirtualCores;
}
+ if (rs instanceof FairScheduler) {
+ FairScheduler fs = (FairScheduler) rs;
+ totalUsedResourcesAcrossPartition = new ResourceInfo(fs.getQueueManager().getRootQueue().getResourceUsage());
+ totalClusterResourcesAcrossPartition = new ResourceInfo(fs.getClusterResource());
+ }
Review comment:
It seems we also need to add the snippet below to the FairScheduler conditional branch if we move the code segment to else if clause. I'm not sure which is "_less ugly_". Do you have any suggestion on this @jiwq ?
```
this.totalMB = availableMB + allocatedMB;
this.totalVirtualCores = availableVirtualCores + allocatedVirtualCores;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org