You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/20 08:03:38 UTC
[GitHub] [shardingsphere] TeslaCN opened a new pull request, #17830: Fix resource leak when error occurred in ShardingSpherePipelineDataSourceCreator
TeslaCN opened a new pull request, #17830:
URL: https://github.com/apache/shardingsphere/pull/17830
Fixes #17808.
Before:
Thousands of instances of HikariDataSource are not shutdown.
After:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #17830: Fix resource leak when error occurred in ShardingSpherePipelineDataSourceCreator
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17830:
URL: https://github.com/apache/shardingsphere/pull/17830#issuecomment-1132661217
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17830?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17830](https://codecov.io/gh/apache/shardingsphere/pull/17830?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32b5d36) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d06b0858043c30ceabebbeb81aeac576b593ac85?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d06b085) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #17830 +/- ##
============================================
- Coverage 59.12% 59.11% -0.01%
Complexity 2134 2134
============================================
Files 3602 3602
Lines 53462 53467 +5
Branches 9118 9118
============================================
Hits 31609 31609
- Misses 19173 19178 +5
Partials 2680 2680
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17830?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eator/ShardingSpherePipelineDataSourceCreator.java](https://codecov.io/gh/apache/shardingsphere/pull/17830/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9kYXRhL3BpcGVsaW5lL2RhdGFzb3VyY2UvY3JlYXRvci9TaGFyZGluZ1NwaGVyZVBpcGVsaW5lRGF0YVNvdXJjZUNyZWF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17830?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17830?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d06b085...32b5d36](https://codecov.io/gh/apache/shardingsphere/pull/17830?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #17830: Fix resource leak when error occurred in ShardingSpherePipelineDataSourceCreator
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #17830:
URL: https://github.com/apache/shardingsphere/pull/17830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org