You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org> on 2011/03/28 18:35:05 UTC
[jira] [Created] (HADOOP-7210) Chown command is not working from
FSShell.
Chown command is not working from FSShell.
------------------------------------------
Key: HADOOP-7210
URL: https://issues.apache.org/jira/browse/HADOOP-7210
Project: Hadoop Common
Issue Type: Bug
Components: fs
Environment: Linux
Reporter: Uma Maheswara Rao G
Assignee: Uma Maheswara Rao G
chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012463#comment-13012463 ]
Daryn Sharp commented on HADOOP-7210:
-------------------------------------
Good idea, I think that would work too. In that case, would chgrp even need to inherit from chown?
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013925#comment-13013925 ]
Hudson commented on HADOOP-7210:
--------------------------------
Integrated in Hadoop-Common-trunk #647 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/647/])
HADOOP-7210. Chown command is not working from FSShell. Contributed by Uma Maheswara Rao G
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.23.0
>
> Attachments: HADOOP-7210.1.patch, HADOOP-7210.2.patch, HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012469#comment-13012469 ]
Uma Maheswara Rao G commented on HADOOP-7210:
---------------------------------------------
In this case ChgrpHandler need not extend the ChownHandler
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7210:
----------------------------------------
Status: Patch Available (was: Open)
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7210:
----------------------------------------
Attachment: HADOOP-7210.2.patch
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.1.patch, HADOOP-7210.2.patch, HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013797#comment-13013797 ]
Hudson commented on HADOOP-7210:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #540 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/540/])
HADOOP-7210. Chown command is not working from FSShell. Contributed by Uma Maheswara Rao G
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.23.0
>
> Attachments: HADOOP-7210.1.patch, HADOOP-7210.2.patch, HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7210:
--------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk, thanks Uma
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.23.0
>
> Attachments: HADOOP-7210.1.patch, HADOOP-7210.2.patch, HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012589#comment-13012589 ]
Todd Lipcon commented on HADOOP-7210:
-------------------------------------
Couple small comments:
- Rather than injecting the "Extn" class into the FS Cache, could you instead set up a new scheme by setting "fs.testfs.impl" to your test class and then calling a command on testfs:///foo? Seems like a cleaner test pattern.
- In ChgrpHandler you don't need to check for group == null anymore, right?
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.1.patch, HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012180#comment-13012180 ]
Daryn Sharp commented on HADOOP-7210:
-------------------------------------
The root problem is that a prior bug that remove the FileSystem var from the ctors. This left two ctors with a String signature. Changing one of the three commands to have a ctor of (String, String) just for the purpose of working around the ambiguity doesn't seem right.
My suggestion would be to split the user/group mode parsing into a separate parseOwnerGroup (or similar) method. Chown's ctor calls this new method with its own impl, Chgrp overrides the method with it's own impl.
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012127#comment-13012127 ]
Uma Maheswara Rao G commented on HADOOP-7210:
---------------------------------------------
Based on the passed arguments, it is creating the Handlers. when argument is -chown, it is creating ChownHandler.
{code}
else if (cmd.equals("-chown")) {
handler = new ChownHandler(argv[startIndex++]);
{code}
But here the problem is, it is not populating owner, group values in this constructor. just it is calling supper. It is not populating the group, owner.
{code}
protected ChownHandler(String cmd) { //for chgrp
super(cmd);
}
{code}
Since it is not populating, setOwner will not be invoked on fileSystem.So permissions will not change.
{code}
if (newOwner != null || newGroup != null) {
try {
srcFs.setOwner(file.getPath(), newOwner, newGroup);
{code}
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013789#comment-13013789 ]
Hadoop QA commented on HADOOP-7210:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12474960/HADOOP-7210.2.patch
against trunk revision 1087097.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/324//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/324//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/324//console
This message is automatically generated.
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.1.patch, HADOOP-7210.2.patch, HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012927#comment-13012927 ]
Uma Maheswara Rao G commented on HADOOP-7210:
---------------------------------------------
Thanks Todd for the comments,
I have fixed the comments, please check.
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.1.patch, HADOOP-7210.2.patch, HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7210:
----------------------------------------
Attachment: HADOOP-7210.1.patch
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.1.patch, HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012584#comment-13012584 ]
Hadoop QA commented on HADOOP-7210:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12474892/HADOOP-7210.1.patch
against trunk revision 1086455.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/323//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/323//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/323//console
This message is automatically generated.
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.1.patch, HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012415#comment-13012415 ]
Uma Maheswara Rao G commented on HADOOP-7210:
---------------------------------------------
Hi Daryn,
Thanks for your comments.
I agree with you. But I have one suggestion. We can directly override the run method in Chown and Chgrp directly from CmdHandler. Currently the ChgrpHandler extends the ChownHandler thereby use the same run method. This might have been done to save some lines of code. But because of this, we are providing additional constructor and additional if checks in the code.
For example, owner details check is not applicable for chgrp command. The owner will be always null, still we will execute the owner checks for ChgrepHandler also.
{code}
String newOwner = (owner == null || owner.equals(file.getOwner())) ?
null : owner;
....
....
if (newOwner != null || newGroup != null) {
{code}
Instead of this, Both Chown and Chgrp handlers can directly extend from CmdHandler provide the run method.
Please tell me your suggestion on this.
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013721#comment-13013721 ]
Todd Lipcon commented on HADOOP-7210:
-------------------------------------
+1, looks good to me and verified that it fixes the tests. waiting on the hudson results before commit.
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.1.patch, HADOOP-7210.2.patch, HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7210:
----------------------------------------
Attachment: HADOOP-7210.patch
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7210) Chown command is not working from
FSShell.
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012532#comment-13012532 ]
Daryn Sharp commented on HADOOP-7210:
-------------------------------------
+1 Nice work
> Chown command is not working from FSShell.
> ------------------------------------------
>
> Key: HADOOP-7210
> URL: https://issues.apache.org/jira/browse/HADOOP-7210
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HADOOP-7210.1.patch, HADOOP-7210.patch
>
>
> chown command is not invoking the setOwner on FileSystem.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira