You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/29 07:20:55 UTC
[GitHub] [pulsar] liudezhi2098 opened a new pull request, #15386: [DOC] add examples for creates a Python Client use a listener_name
liudezhi2098 opened a new pull request, #15386:
URL: https://github.com/apache/pulsar/pull/15386
Master Issue: #15353
Preview looks good:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15386: [DOC] add examples for creates a Python Client use a listener_name
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15386:
URL: https://github.com/apache/pulsar/pull/15386#issuecomment-1112957039
@liudezhi2098:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #15386: [DOC] add examples for creates a Python Client use a listener_name
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15386:
URL: https://github.com/apache/pulsar/pull/15386#discussion_r861570535
##########
site2/docs/client-libraries-python.md:
##########
@@ -167,6 +167,17 @@ while True:
client.close()
```
+### Use listener_name
+To ensure clients in both internal and external networks can connect to a Pulsar cluster, Pulsar introduces [advertisedListeners](concepts-multiple-advertised-listeners.md).
+
+The following example creates a Python Client use a listener_name:
Review Comment:
```suggestion
The following example creates a Python client using multiple advertised listeners:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #15386: [feature][doc] add examples for creates a Python Client use a listener_name
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #15386:
URL: https://github.com/apache/pulsar/pull/15386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #15386: [DOC] add examples for creates a Python Client use a listener_name
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15386:
URL: https://github.com/apache/pulsar/pull/15386#discussion_r861571043
##########
site2/docs/client-libraries-python.md:
##########
@@ -167,6 +167,17 @@ while True:
client.close()
```
+### Use listener_name
Review Comment:
```suggestion
### Create a Python client with multiple advertised listeners
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #15386: [DOC] add examples for creates a Python Client use a listener_name
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15386:
URL: https://github.com/apache/pulsar/pull/15386#issuecomment-1113020375
In addition, I propose more changes to the PR:
- Add [feature] to the PR title to conform to the latest naming convention.
- Add "- [x] `doc` " in the PR description to attach the doc label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org