You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rodent of Unusual Size <Ke...@Golux.Com> on 2000/06/02 18:03:03 UTC
Re: cvs commit: apache-1.3/src/modules/proxy mod_proxy.h proxy_util.c
wrowe@locus.apache.org wrote:
>
> Log:
> PR: 1462, 2216, 3645
> Submitted by: David Whitmarsh <da...@dial.pipex.com>
> Reviewed by: William Rowe
This breaks the build of mod_proxy on Linux. I'm not entirely
sure what's going on here; does the following fix this and have
the desired effect?
Index: proxy_util.c
===================================================================
RCS file: /home/cvs/apache-1.3/src/modules/proxy/proxy_util.c,v
retrieving revision 1.89
diff -u -r1.89 proxy_util.c
--- proxy_util.c 2000/06/02 14:49:59 1.89
+++ proxy_util.c 2000/06/02 16:02:52
@@ -1324,8 +1324,8 @@
#else
- static APACHE_TLS per_thread_data sptd;
- return *sptd;
+ static APACHE_TLS struct per_thread_data sptd;
+ return &sptd;
#endif
}
--
#ken P-)}
Ken Coar <http://Golux.Com/coar/>
Apache Software Foundation <http://www.apache.org/>
"Apache Server for Dummies" <http://Apache-Server.Com/>
"Apache Server Unleashed" <http://ApacheUnleashed.Com/>
Re: cvs commit: apache-1.3/src/modules/proxy mod_proxy.h proxy_util.c
Posted by David Whitmarsh <da...@dial.pipex.com>.
Rodent of Unusual Size wrote:
> wrowe@locus.apache.org wrote:
> >
> > Log:
> > PR: 1462, 2216, 3645
> > Submitted by: David Whitmarsh <da...@dial.pipex.com>
> > Reviewed by: William Rowe
>
> This breaks the build of mod_proxy on Linux. I'm not entirely
> sure what's going on here; does the following fix this and have
> the desired effect?
>
> Index: proxy_util.c
> ===================================================================
> RCS file: /home/cvs/apache-1.3/src/modules/proxy/proxy_util.c,v
> retrieving revision 1.89
> diff -u -r1.89 proxy_util.c
> --- proxy_util.c 2000/06/02 14:49:59 1.89
> +++ proxy_util.c 2000/06/02 16:02:52
> @@ -1324,8 +1324,8 @@
>
> #else
>
> - static APACHE_TLS per_thread_data sptd;
> - return *sptd;
> + static APACHE_TLS struct per_thread_data sptd;
> + return &sptd;
>
> #endif
> }
>
Whoops.
I believe you are correct. I only found this a couple of weeks ago
myself when I finally santitised my laptop by replacing Win95 with
linux.
David
RE: cvs commit: apache-1.3/src/modules/proxy mod_proxy.h proxy_util.c
Posted by "William A. Rowe, Jr." <wr...@lnd.com>.
Yep, that did it. Typo ouside of the Win build (promise to
throw a GB drive in my old 386 and get linux or free bsd up
within a few weeks :-)
> -----Original Message-----
> From: Rodent of Unusual Size [mailto:Ken.Coar@Golux.Com]
> Sent: Friday, June 02, 2000 11:03 AM
> To: new-httpd@apache.org
> Subject: Re: cvs commit: apache-1.3/src/modules/proxy mod_proxy.h
> proxy_util.c
>
>
> wrowe@locus.apache.org wrote:
> >
> > Log:
> > PR: 1462, 2216, 3645
> > Submitted by: David Whitmarsh <da...@dial.pipex.com>
> > Reviewed by: William Rowe
>
> This breaks the build of mod_proxy on Linux. I'm not entirely
> sure what's going on here; does the following fix this and have
> the desired effect?
>
> Index: proxy_util.c
> ===================================================================
> RCS file: /home/cvs/apache-1.3/src/modules/proxy/proxy_util.c,v
> retrieving revision 1.89
> diff -u -r1.89 proxy_util.c
> --- proxy_util.c 2000/06/02 14:49:59 1.89
> +++ proxy_util.c 2000/06/02 16:02:52
> @@ -1324,8 +1324,8 @@
>
> #else
>
> - static APACHE_TLS per_thread_data sptd;
> - return *sptd;
> + static APACHE_TLS struct per_thread_data sptd;
> + return &sptd;
>
> #endif
> }
>
> --
> #ken P-)}
>
> Ken Coar <http://Golux.Com/coar/>
> Apache Software Foundation <http://www.apache.org/>
> "Apache Server for Dummies" <http://Apache-Server.Com/>
> "Apache Server Unleashed" <http://ApacheUnleashed.Com/>
>