[GitHub] [spark] juliuszsompolski commented on issue #26340: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver with all code and UT

[GitBox <gi...@apache.org>]

juliuszsompolski commented on issue #26340: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver  with all code and UT
URL: https://github.com/apache/spark/pull/26340#issuecomment-548372976
 
 
   > Implement Type in scala since spark con't support all type of hive
   
   What are the changes compared to Hive? Ideally, it would be best to integrate with Spark type system fully, but if we have to map to Hive types, maybe we could keep this code in Java.
   
   > Implement Service/AbstractService prepare for remove hive conf in future
   
   What is changed there compared to Hive? Can it stay with the Hive java files?
   
   > Implement HiveAuthFactory since between 1.2.1/2.3.5, their delegation token managerment > changed. Impelment on DelegationTokenMnagerment by scala
   
   Could you write a paragraph of context for that in the description?
   
   > Remove GlobalHivercFileProcessor setFetchSize processGlobalInitFileetc
   
   Could you add some description what it is and why it is not used?
   
   > Remove unused openSession openSessionWithImpersonation in CLIService
   
   Are we sure it is unused?
   I don't really know about how these delegation tokens are used.
   
   > Implement it's own thrift client code. CLIServiceClient ThrictCLIServiceClient
   
   What is changed there compared to Hive? Can it stay with the Hive java files?
   
   > Construct RowSet with StructType and Row
   > MV tableTypeString from SparkMetadataOperationUtils to SparkMetadataOperation
   > Since there are tableTypeString in SparkMetadataOperation remove ClassicTypeMapping, HiveTableTypeMapping, TableTypeMapping and TableTypeMappingFactory
   > Add new method GetQueryId, SetClientInfo for thrift version v11 in ThriftCLIService
   > Add statementid to Operation for implement GetQueryId
   > Copy hive-thriftserver test to spark-thriftserver and remove ThriftSeverShimUtils about test UT, since we won't need it.
   > Implement all oepration for spark since it execute in different way
   
   No questions for these ones right now...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org