You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/05/18 16:39:41 UTC

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #781: MINIFICPP-1214: Converts H2O Processors to use ALv2 compliant H20-3 library

szaszm commented on pull request #781:
URL: https://github.com/apache/nifi-minifi-cpp/pull/781#issuecomment-630301959


   I have a concern regarding the contribution of these processors. Myself and probably most minifi c++ contributors are unfamiliar with H2O, which makes it problematic to maintain the new processors. 
   
   The first problem I ran into while reviewing #784 is that I couldn't easily verify whether those changes would break these new processors.
   
   This problem (and others) could be mostly solved if you could submit integration tests covering these processors. Could you do that?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org