[GitHub] ashb commented on a change in pull request #4636: [AIRFLOW-3737] Kubernetes executor cannot handle long dag/task names

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #4636: [AIRFLOW-3737] Kubernetes executor cannot handle long dag/task names
URL: https://github.com/apache/airflow/pull/4636#discussion_r252719426
 
 

 ##########
 File path: airflow/contrib/kubernetes/worker_configuration.py
 ##########
 @@ -226,6 +227,9 @@ def make_pod(self, namespace, worker_uuid, pod_id, dag_id, task_id, execution_da
         if gcp_sa_key:
             annotations['iam.cloud.google.com/service-account'] = gcp_sa_key
 
+        annotations['dag_id'] = dag_id
 
 Review comment:
   Is it worth "namespacing" these annotations to something like `org.apache.airflow.dag_id`?
   
   (I don't know if that's recommended or needed in kube-land)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services