[jira] Closed: (WICKET-593) equals() in ResourceStreamRequestTarget compares the wrong filename

["Johan Compagner (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner closed WICKET-593.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.0-beta2
                   1.2.7
         Assignee: Johan Compagner

> equals() in ResourceStreamRequestTarget compares the wrong filename
> -------------------------------------------------------------------
>
>                 Key: WICKET-593
>                 URL: https://issues.apache.org/jira/browse/WICKET-593
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.2.6
>            Reporter: Kent Tong
>         Assigned To: Johan Compagner
>            Priority: Trivial
>             Fix For: 1.2.7, 1.3.0-beta2
>
>
> In ResourceStreamRequestTarget, the equals() method is:
> 	public boolean equals(Object obj)
> 	{
> 		if (obj instanceof ResourceStreamRequestTarget)
> 		{
> 			ResourceStreamRequestTarget that = (ResourceStreamRequestTarget)obj;
> 			return resourceStream.equals(that.resourceStream)
> 					&& ((fileName != null) ? fileName.equals(this.fileName) : true);
> 		}
> 		return false;
> 	}
> Note that the fileName is comparing to itself. It should really be: 
> 	fileName.equals(that.fileName)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.