You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Deacon Marcus <de...@wwtech.pl> on 2001/11/12 22:41:43 UTC

RE: Tomcat4, taglibs, and pageContext.include

Hi,
I need to upgrade to latest T4 ASAP, and I need to have my tags working...
;/
So, I guess I must get source and recompile after downgrading a few files -
could you please recommend what files exactly I need to "downgrade" and to
what versions to get rid of the mentioned "feature"?
And, maybe the problem's worth a paragraph or two (plus links to
downloadable patch) in FAQ?

Greetings, deacon Marcus

> -----Original Message-----
> From: Rickard Öberg [mailto:rickard@xpedio.com]
> Sent: Saturday, October 27, 2001 4:14 PM
> To: tomcat-dev@jakarta.apache.org
> Subject: Tomcat4, taglibs, and pageContext.include
>
>
> Hi!
>
> Due to some recent subtle changes in Tomcat (Jasper and servlet API to
> be precise) it is no longer possible to implement jsp:include tags. This
> now results in the infamous "May not flush in custom tags" (or similar)
> error message.
>
> Two questions:
> * Why was this change made? (It is likely to break any include-tag ever
> written)
> * How is one supposed to write such tags now? I found some code in
> Tomcat4 suggesting one should use RequestDispatcher.include along with a
> response wrapper that provides the JspWriter on getWriter, but it seems
> hackish (and won't work well with 2.2 servlet engines).
>
> Any explanations would be appreciated. I believe it was Craig who
> committed these changes.
>
> /Rickard
>
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

RE: Tomcat4, taglibs, and pageContext.include

Posted by Deacon Marcus <de...@wwtech.pl>.
Hi,

> -----Original Message-----
> From: Deacon Marcus [mailto:deacon_marcus@wwtech.pl]
> Sent: Monday, November 12, 2001 10:42 PM
> To: Tomcat Developers Mailing List
> Subject: RE: Tomcat4, taglibs, and pageContext.include
>
>
> Hi,
> I need to upgrade to latest T4 ASAP, and I need to have my tags working...
> ;/
> So, I guess I must get source and recompile after downgrading a
> few files -
> could you please recommend what files exactly I need to "downgrade" and to
> what versions to get rid of the mentioned "feature"?
> And, maybe the problem's worth a paragraph or two (plus links to
> downloadable patch) in FAQ?

Would it be enough to change:

    public void include(String relativeUrlPath)
        throws ServletException, IOException
    {
        JspRuntimeLibrary.include((HttpServletRequest) request,
                                  (HttpServletResponse) response,

// FROM:
                                  relativeUrlPath, out, true);

// TO:
                                  relativeUrlPath, out, false);
        /*
        String path = getAbsolutePathRelativeToContext(relativeUrlPath);
        context.getRequestDispatcher(path).include(
	    request, new ServletResponseWrapperInclude(response, out));
        */
    }

In org.apache.jasper.runtime.PageContextImpl ?

Greetings, deacon Marcus

>
> > -----Original Message-----
> > From: Rickard Öberg [mailto:rickard@xpedio.com]
> > Sent: Saturday, October 27, 2001 4:14 PM
> > To: tomcat-dev@jakarta.apache.org
> > Subject: Tomcat4, taglibs, and pageContext.include
> >
> >
> > Hi!
> >
> > Due to some recent subtle changes in Tomcat (Jasper and servlet API to
> > be precise) it is no longer possible to implement jsp:include tags. This
> > now results in the infamous "May not flush in custom tags" (or similar)
> > error message.
> >
> > Two questions:
> > * Why was this change made? (It is likely to break any include-tag ever
> > written)
> > * How is one supposed to write such tags now? I found some code in
> > Tomcat4 suggesting one should use RequestDispatcher.include along with a
> > response wrapper that provides the JspWriter on getWriter, but it seems
> > hackish (and won't work well with 2.2 servlet engines).
> >
> > Any explanations would be appreciated. I believe it was Craig who
> > committed these changes.
> >
> > /Rickard
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> >
> >
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>