You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Yunyung (via GitHub)" <gi...@apache.org> on 2025/10/08 09:47:30 UTC
[PR] MINOR: ignore result of "missing build scan" [kafka]
Yunyung opened a new pull request, #20659:
URL: https://github.com/apache/kafka/pull/20659
Workaround: Always mark as successful, not show as failing, for those branches (4.0, 4.1) without the KAFKA-18748 patches.
See https://github.com/apache/kafka/pull/20648#issuecomment-3380437656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ignore result of "missing build scan" [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #20659:
URL: https://github.com/apache/kafka/pull/20659#discussion_r2413500238
##########
.github/workflows/ci-complete.yml:
##########
@@ -89,7 +89,7 @@ jobs:
url: '${{ github.event.workflow_run.html_url }}'
description: 'Could not find build scan'
context: Gradle Build Scan / ${{ env.status-context }}
- state: 'error'
+ state: 'success' # WAR: Mark as successful, not show as failing, for those branches without the KAFKA-18748 patches
Review Comment:
KAFKA-18748 is not the only reason. The other cause is the difference in supported JDKs. For example, `trunk` now supports JDK 25, but the `4.1` branch does not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ignore result of "missing build scan" [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on PR #20659:
URL: https://github.com/apache/kafka/pull/20659#issuecomment-3407204557
Thanks for the review! Addressed the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ignore result of "missing build scan" [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on PR #20659:
URL: https://github.com/apache/kafka/pull/20659#issuecomment-3380860640
Sure. Revert the failed approach from https://github.com/Yunyung/kafka/commit/fa2496bb9179bb1799a292cec47f97f73e5956f8 in latest comimt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ignore result of "missing build scan" [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on code in PR #20659:
URL: https://github.com/apache/kafka/pull/20659#discussion_r2413552496
##########
.github/workflows/ci-complete.yml:
##########
@@ -89,7 +89,7 @@ jobs:
url: '${{ github.event.workflow_run.html_url }}'
description: 'Could not find build scan'
context: Gradle Build Scan / ${{ env.status-context }}
- state: 'error'
+ state: 'success' # WAR: Mark as successful, not show as failing, for those branches without the KAFKA-18748 patches
Review Comment:
Updated, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ignore result of "missing build scan" [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #20659:
URL: https://github.com/apache/kafka/pull/20659#issuecomment-3380797182
@Yunyung could you please revert previous failed approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ignore result of "missing build scan" [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #20659:
URL: https://github.com/apache/kafka/pull/20659#discussion_r2427555450
##########
.github/workflows/ci-complete.yml:
##########
@@ -89,7 +89,7 @@ jobs:
url: '${{ github.event.workflow_run.html_url }}'
description: 'Could not find build scan'
context: Gradle Build Scan / ${{ env.status-context }}
- state: 'error'
+ state: 'success' # WAR: Always mark as successful, not as failing, for non-trunk branches; real solution to follow in KAFKA-19768
Review Comment:
nit: "WAR" i assume means workaround, but isn't really clear. I would just have the comment reference the JIRA and explain why we're doing this for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ignore result of "missing build scan" [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #20659:
URL: https://github.com/apache/kafka/pull/20659#issuecomment-3385510482
@mumrah What do you think? I want to use a simple fix to eliminate the build errors on the 4.1 and 4.0 branches. We can discuss rewriting `ci-complete` later in KAFKA-19768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ignore result of "missing build scan" [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #20659:
URL: https://github.com/apache/kafka/pull/20659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org