[GitHub] [flink] dawidwys commented on a change in pull request #17440: [FLINK-24468][runtime] Wait for the channel activation before creating partition request client

[GitBox <gi...@apache.org>]

dawidwys commented on a change in pull request #17440:
URL: https://github.com/apache/flink/pull/17440#discussion_r725972098



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -788,9 +788,14 @@ private void scheduleBufferDebloater() {
 
     @VisibleForTesting
     void debloat() {
-        long throughput = throughputCalculator.calculateThroughput();
-        if (bufferDebloater != null) {
-            bufferDebloater.recalculateBufferSize(throughput);
+        try {
+            long throughput = throughputCalculator.calculateThroughput();
+            if (bufferDebloater != null) {
+                bufferDebloater.recalculateBufferSize(throughput);
+            }
+            // Don't fail the further calculation if the current one fails.
+        } catch (Throwable ex) {
+            LOG.error("Throughput calculation fails, try next time.", ex);

Review comment:
       Is it an error if we continue processing? IMO, at best it should be `warn`, I am event thinking if it shouldn't be just a `debug`. What are users supposed to do with the line in logs?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org