You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "iGoogle-ink (via GitHub)" <gi...@apache.org> on 2023/05/22 07:49:24 UTC
[GitHub] [rocketmq-client-go] iGoogle-ink opened a new pull request, #1065: [PanicFix] fix trace init nil pointer panic and clientid add group name at first [#1062]
iGoogle-ink opened a new pull request, #1065:
URL: https://github.com/apache/rocketmq-client-go/pull/1065
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] iGoogle-ink commented on pull request #1065: [PanicFix] issue#1062 fix trace init nil pointer panic and clientid add group name at first
Posted by "iGoogle-ink (via GitHub)" <gi...@apache.org>.
iGoogle-ink commented on PR #1065:
URL: https://github.com/apache/rocketmq-client-go/pull/1065#issuecomment-1600830493
> 直接修改clientId影响的内容较多，可以参考下java sdk的实现逻辑，为轨迹producer设置不同的groupName来解决 @iGoogle-ink
你说的 producer 和 consumer 没问题，但是当使用 tracer 的时候，tracer 默认初始化的是固定的，没办法改，如果不改 clientid，可以考虑把 tracer 的初始化部分配置开放设置
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] iGoogle-ink commented on pull request #1065: [PanicFix] issue#1062 fix trace init nil pointer panic and clientid add group name at first
Posted by "iGoogle-ink (via GitHub)" <gi...@apache.org>.
iGoogle-ink commented on PR #1065:
URL: https://github.com/apache/rocketmq-client-go/pull/1065#issuecomment-1556713367
fix #1062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] cserwen commented on pull request #1065: [PanicFix] issue#1062 fix trace init nil pointer panic and clientid add group name at first
Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen commented on PR #1065:
URL: https://github.com/apache/rocketmq-client-go/pull/1065#issuecomment-1599941368
直接修改clientId影响的内容较多，可以参考下java sdk的实现逻辑，为轨迹producer设置不同的groupName来解决 @iGoogle-ink
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] cserwen commented on pull request #1065: [PanicFix] issue#1062 fix trace init nil pointer panic and clientid add group name at first
Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen commented on PR #1065:
URL: https://github.com/apache/rocketmq-client-go/pull/1065#issuecomment-1605850930
> > 直接修改clientId影响的内容较多，可以参考下java sdk的实现逻辑，为轨迹producer设置不同的groupName来解决 @iGoogle-ink
>
> 你说的 producer 和 consumer 没问题，但是当使用 tracer 的时候，tracer 默认初始化的是固定的，没办法改，如果不改 clientid，可以考虑把 tracer 的初始化部分配置开放设置
参考 java SDK 的实现 https://github.com/apache/rocketmq/blob/develop/client/src/main/java/org/apache/rocketmq/client/trace/AsyncTraceDispatcher.java#L108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] go-pay closed pull request #1065: [PanicFix] issue#1062 fix trace init nil pointer panic and clientid add group name at first
Posted by "go-pay (via GitHub)" <gi...@apache.org>.
go-pay closed pull request #1065: [PanicFix] issue#1062 fix trace init nil pointer panic and clientid add group name at first
URL: https://github.com/apache/rocketmq-client-go/pull/1065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org