You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/19 05:00:22 UTC
[GitHub] [airflow] turbaszek opened a new pull request #13180: Disable suppress_logs_and_warning in cli when debugging
turbaszek opened a new pull request #13180:
URL: https://github.com/apache/airflow/pull/13180
In some cases commands like 'dags list' can be used for debug purposes.
The problem is that we are suppresing logs and warnings in some cases
to make the output nice and clean. This commit disable this functionality
if logging level is set to DEBUG.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #13180: Disable suppress_logs_and_warning in cli when debugging
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #13180:
URL: https://github.com/apache/airflow/pull/13180#issuecomment-749166512
Make sense to me, and my opinion about that alternative solution was not strong anyway. Will approve, but please re-push to re-run the CI before we merge this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #13180: Disable suppress_logs_and_warning in cli when debugging
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #13180:
URL: https://github.com/apache/airflow/pull/13180#issuecomment-749164795
> So an alternative solution can be disable `suppress_logs_and_warning` for `table` output?
I suppose you meant the json and yaml output formats. Sure, this is an option but in my opinion commands should provide requested information and nothing more. Especially that in some cases the errors and warnings (for example from dags) can be a real mess
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #13180: Disable suppress_logs_and_warning in cli when debugging
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #13180:
URL: https://github.com/apache/airflow/pull/13180#issuecomment-750296340
> Some CLI tests are failing :)
Should be fixed now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #13180: Disable suppress_logs_and_warning in cli when debugging
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #13180:
URL: https://github.com/apache/airflow/pull/13180#issuecomment-749239861
In my opinion, it's worth adding the --verbose switch to enable logs.
Mainly to make it easier to read log import, which is now only available when you run:
```
python -c "from airflow.models.dagbag import DagBag; DagBag()"
```
These logs now don't show up when you start ``airflow dags liist``, so a little switch to bring those logs back would be helpful.
```
airflow dags list -v
```
For now, I always remove this decorator for development:
@turbaszek @XD-DENG WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13180: Disable suppress_logs_and_warning in cli when debugging
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13180:
URL: https://github.com/apache/airflow/pull/13180#issuecomment-749176246
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13180: Disable suppress_logs_and_warning in cli when debugging
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13180:
URL: https://github.com/apache/airflow/pull/13180#issuecomment-749943190
Some CLI tests are failing :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13180: Disable suppress_logs_and_warning in cli when debugging
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13180:
URL: https://github.com/apache/airflow/pull/13180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13180: Disable suppress_logs_and_warning in cli when debugging
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13180:
URL: https://github.com/apache/airflow/pull/13180#issuecomment-749239861
In my opinion, it's worth adding the --verbose switch to enable logs.
Mainly to make it easier to read log import, which is now only available when you run:
```
python -c "from airflow.models.dagbag import DagBag; DagBag()"
```
These logs now don't show up when you start ``airflow dags liist``, so a little switch to bring those logs back would be helpful.
```
airflow dags list -v
```
@turbaszek @XD-DENG WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13180: Disable suppress_logs_and_warning in cli when debugging
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13180:
URL: https://github.com/apache/airflow/pull/13180#issuecomment-750303972
Random test failing! Merging!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13180: Disable suppress_logs_and_warning in cli when debugging
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13180:
URL: https://github.com/apache/airflow/pull/13180#issuecomment-749928067
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org