[GitHub] [incubator-livy] yiheng commented on a change in pull request #259: [LIVY-714][SERVER] Fix cannot remove the app in leakedAppTags when timeout

[GitBox <gi...@apache.org>]

yiheng commented on a change in pull request #259: [LIVY-714][SERVER] Fix cannot remove the app in leakedAppTags when timeout
URL: https://github.com/apache/incubator-livy/pull/259#discussion_r348946192
 
 

 ##########
 File path: server/src/main/scala/org/apache/livy/utils/SparkYarnApp.scala
 ##########
 @@ -73,20 +73,23 @@ object SparkYarnApp extends Logging {
         if (!leakedAppTags.isEmpty) {
           // kill the app if found it and remove it if exceeding a threshold
           val iter = leakedAppTags.entrySet().iterator()
-          var isRemoved = false
           val now = System.currentTimeMillis()
           val apps = yarnClient.getApplications(appType).asScala
+
           while(iter.hasNext) {
+            var isRemoved = false
             val entry = iter.next()
+
             apps.find(_.getApplicationTags.contains(entry.getKey))
               .foreach({ e =>
                 info(s"Kill leaked app ${e.getApplicationId}")
                 yarnClient.killApplication(e.getApplicationId)
                 iter.remove()
                 isRemoved = true
               })
+
             if (!isRemoved) {
-              if ((entry.getValue - now) > sessionLeakageCheckTimeout) {
+              if ((now - entry.getValue) > sessionLeakageCheckTimeout) {
 
 Review comment:
   A unit test for this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services