[jira] [Commented] (SOLR-6360) Unnecessary Content-Charset header in HttpSolrServer

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092551#comment-14092551 ] 

ASF subversion and git services commented on SOLR-6360:
-------------------------------------------------------

Commit 1617218 from [~thetaphi] in branch 'dev/trunk'
[ https://svn.apache.org/r1617218 ]

SOLR-6360: Remove bogus "Content-Charset" header in HttpSolrServer

> Unnecessary Content-Charset header in HttpSolrServer
> ----------------------------------------------------
>
>                 Key: SOLR-6360
>                 URL: https://issues.apache.org/jira/browse/SOLR-6360
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 3.6, 4.9
>            Reporter: Michael Ryan
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 5.0, 4.10
>
>         Attachments: SOLR-6360.patch
>
>
> The httpclient code in HttpSolrServer currently sets a "Content-Charset" header when making a POST request:
> {code}post.setHeader("Content-Charset", "UTF-8");{code}
> As far as I know this is not a real header and is not necessary. It seems this was a mistake in the original implementation of this class, when converting from httpclient v3 to httpclient v4. CommonsHttpSolrServer did this, which is what the line of code above seems to have been based on:
> {code}post.getParams().setContentCharset("UTF-8");{code}
> The actual way to set the charset in httpclient v4 is already being done correctly, with these lines:
> {code}parts.add(new FormBodyPart(p, new StringBody(v, StandardCharsets.UTF_8)));
> post.setEntity(new UrlEncodedFormEntity(postParams, StandardCharsets.UTF_8));{code}
> So basically, the Content-Charset line can just be removed.
> (I think the explicit setting of the Content-Type header also might be unnecessary, but I haven't taken the time to investigate that.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org